Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14.0] Type errors #8721

Closed
boris-petrov opened this issue May 6, 2024 · 0 comments · Fixed by #8723
Closed

[8.14.0] Type errors #8721

boris-petrov opened this issue May 6, 2024 · 0 comments · Fixed by #8723
Labels
ts TypeScript

Comments

@boris-petrov
Copy link
Contributor

Description

There are type-errors in version 8.14.0:

node_modules/.pnpm/[email protected]/node_modules/video.js/dist/types/spatial-navigation.d.ts:112:48 - error TS2304: Cannot find name 'Component'.

112     getCurrentComponent(target?: HTMLElement): Component | null;
                                                   ~~~~~~~~~

node_modules/.pnpm/[email protected]/node_modules/video.js/dist/types/spatial-navigation.d.ts:119:20 - error TS2304: Cannot find name 'Component'.

119     add(component: Component): void;
                       ~~~~~~~~~

node_modules/.pnpm/[email protected]/node_modules/video.js/dist/types/spatial-navigation.d.ts:125:23 - error TS2304: Cannot find name 'Component'.

125     remove(component: Component): void;
                          ~~~~~~~~~

node_modules/.pnpm/[email protected]/node_modules/video.js/dist/types/spatial-navigation.d.ts:167:22 - error TS2304: Cannot find name 'Component'.

167     focus(component: Component): void;
                         ~~~~~~~~~

Reduced test case

None

Steps to reproduce

Install video.js and run the TypeScript compiler.

Errors

No response

What version of Video.js are you using?

8.14.0

Video.js plugins used.

No response

What browser(s) including version(s) does this occur with?

N/A

What OS(es) and version(s) does this occur with?

Linux

@boris-petrov boris-petrov added the needs: triage This issue needs to be reviewed label May 6, 2024
@mister-ben mister-ben added ts TypeScript and removed needs: triage This issue needs to be reviewed labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ts TypeScript
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants