Make Disposables compatible with new atom beta (#323)

Author: viddo

.babelrc

@@ -6,5 +6,8 @@
     "transform-runtime"
   ],
   "presets": ["react", ["env", {}]],
+  "ignore": [
+    "lib/Disposables.js"
+  ],
   "sourceMaps": "inline"
 }

lib/Disposables.js

@@ -1,17 +1,11 @@
-/* @flow */
+// NOTE Using standard ES6 code without flow/ES modules here
+// to make the extension of the parent class to work.
+// If applying babel the transpiled code is incompatible and would throw:
+// "Class constructor CompositeDisposable cannot be invoked without 'new'"
+const { Disposable, CompositeDisposable } = require("atom");
 
-import { Disposable, CompositeDisposable } from "atom";
-
-// Make it easier to define side-effects for BaconJS streams
-//
-// Example:
-//   var disposable = new Disposables()
-//   disposable.add(
-//     someStream.onValue(val => {
-//       console.log('will be removed on disposable.dispose()')
-//     }))
-export default class Disposables extends CompositeDisposable {
-  add(...values: Array<atom$IDisposable | Disposables | Function>) {
+class Disposables extends CompositeDisposable {
+  add(...values) {
     for (let val of values) {
       if (!Disposable.isDisposable(val)) {
         if (typeof val === "function") {
@@ -26,3 +20,5 @@ export default class Disposables extends CompositeDisposable {
     }
   }
 }
+
+module.exports = Disposables;

spec/Disposables-spec.js

@@ -0,0 +1,30 @@
+/* @flow */
+
+import Disposables from "../lib/Disposables";
+
+const newFakeDisposable = () => {
+  const spy = jasmine.createSpy("dispose");
+  return {
+    dispose: spy,
+    disposed: () => true
+  };
+};
+
+describe("Disposables", () => {
+  let disposables;
+
+  beforeEach(() => {
+    disposables = new Disposables();
+  });
+
+  describe(".add", () => {
+    it("accepts multiple values", () => {
+      const fake1 = newFakeDisposable();
+      const fake2 = newFakeDisposable();
+      disposables.add(fake1, fake2);
+      disposables.dispose();
+      expect(fake1.dispose).toHaveBeenCalled();
+      expect(fake2.dispose).toHaveBeenCalled();
+    });
+  });
+});