DATA-3440 Add ExportTabularData + deprecate TabularDataByFilter #595
+2,387
−828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
katiepeters
commented
Nov 21, 2024
•
katiepeters
commented
- Adds ExportTabularData method to data service API.
- Marks TabularDataByFilter (and related types) as deprecated.
katiepeters
added
the
ready-for-protos
katiepeters
removed
protos-compiled
ready-for-protos
katiepeters
force-pushed
the
DATA-3440
branch
from
73fa547
to
0e6d96f
Compare
katiepeters
added
the
ready-for-protos
katiepeters
removed
protos-compiled
ready-for-protos
katiepeters
force-pushed
the
DATA-3440
branch
from
402857f
to
24cedd3
Compare
katiepeters
added
the
ready-for-protos
|
I'm going to let Vijay take this one since it's just an API change! |
vijayvuyyuru
approved these changes
Nov 21, 2024
| message ExportTabularDataRequest { | ||
| string part_id = 1; | ||
| string resource_name = 2; | ||
| string resource_subtype = 3; |
There was a problem hiding this comment.
[supernit] I think this should be resource type instead of subtype.
There was a problem hiding this comment.
Keeping it consistent with Katherine's API work. Also, Gloria pointed out: "according to the viam glossary resource type is either component or service and subtype is the actual component/service type like sensor or arm etc"
katiepeters
removed
the
ready-for-protos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.