Remove the ExecutableStack property. It's already on by default in LLD and can't be overridden.

Author: alexrp

doc/configuration/properties.md

@@ -149,9 +149,6 @@ historical reasons.
 * `SymbolVisibility` (`Default`, `Hidden`): Specifies the symbol visibility in
   C/C++ projects when `__attribute__((visibility(...)))` is not specified.
   `Default` (the default 😉) means public, while `Hidden` means private.
-* `ExecutableStack` (`true`, `false`): Enables/disables marking the stack as
-  executable for the resulting binary. Executable stack memory is a significant
-  security risk. Defaults to `false`.
 * `EagerBinding` (`true`, `false`): Enables/disables eager binding of symbols
   when performing dynamic linking at run time. Eager binding has security
   benefits, especially in combination with `RelocationHardening`. It is also

src/samples/zigexe/zigexe.zigproj

@@ -1,6 +1,5 @@
 <Project Sdk="Vezel.Zig.Sdk">
     <PropertyGroup>
-        <ExecutableStack>true</ExecutableStack>
         <OutputType>Exe</OutputType>
     </PropertyGroup>
 

src/sdk/ZigCompile.cs

@@ -57,9 +57,6 @@ public string Configuration
     [Required]
     public bool EagerBinding { get; set; }
 
-    [Required]
-    public bool ExecutableStack { get; set; }
-
     [Required]
     public bool FastMath { get; set; }
 
@@ -558,9 +555,6 @@ void TryAppendWarningSwitch(string name)
         if (RelocationHardening)
             builder.AppendSwitch(isZig ? "-z relro" : "-Wl,-z,relro");
 
-        if (!ExecutableStack)
-            builder.AppendSwitch(isZig ? "-z noexecstack" : "-Wl,-z,noexecstack");
-
         builder.AppendSwitch(isZig ? "-z origin" : "-Wl,-z,origin");
         builder.AppendSwitchIfNotNull(isZig ? "-rpath " : "-Wl,-rpath,", "$ORIGIN");
 

src/sdk/build/Vezel.Zig.Sdk.Build.targets

@@ -54,7 +54,6 @@
                     DocumentationAnalysis="$(DocumentationAnalysis)"
                     EagerBinding="$(EagerBinding)"
                     EnvironmentVariables="ZIG_GLOBAL_CACHE_DIR=$(CachePath)/global; ZIG_LOCAL_CACHE_DIR=$(CachePath)/local"
-                    ExecutableStack="$(ExecutableStack)"
                     FastMath="$(FastMath)"
                     IncludeDirectories="@(IncludeDirectory)"
                     LanguageStandard="$(LanguageStandard)"

src/sdk/build/Vezel.Zig.Sdk.Defaults.targets

@@ -53,7 +53,6 @@
 
     <PropertyGroup>
         <EagerBinding Condition="'$(EagerBinding)' == ''">true</EagerBinding>
-        <ExecutableStack Condition="'$(ExecutableStack)' == ''">false</ExecutableStack>
         <FastMath Condition="'$(FastMath)' == ''">false</FastMath>
         <!-- TODO: https://github.com/vezel-dev/zig-sdk/issues/33 -->
         <LinkTimeOptimization Condition="'$(LinkTimeOptimization)' == ''">false</LinkTimeOptimization>

src/sdk/build/Vezel.Zig.Sdk.Test.targets

@@ -30,7 +30,6 @@
                     DocumentationAnalysis="$(DocumentationAnalysis)"
                     EagerBinding="$(EagerBinding)"
                     EnvironmentVariables="ZIG_GLOBAL_CACHE_DIR=$(CachePath)/global; ZIG_LOCAL_CACHE_DIR=$(CachePath)/local"
-                    ExecutableStack="$(ExecutableStack)"
                     FastMath="$(FastMath)"
                     IncludeDirectories="@(IncludeDirectory)"
                     LanguageStandard="$(LanguageStandard)"