Fix some analyzer violations.

Author: alexrp

src/benchmarks/CelerityBenchmarkConfig.cs

@@ -12,7 +12,7 @@ public CelerityBenchmarkConfig(bool test, string? filter)
             _ = AddValidator(JitOptimizationsValidator.FailOnError);
 
         if (filter != null)
-            _ = AddFilter(new GlobFilter(new[] { filter }));
+            _ = AddFilter(new GlobFilter([filter]));
 
         _ = WithOptions(ConfigOptions.JoinSummary | ConfigOptions.StopOnFirstError)
             .WithArtifactsPath(Path.Join(Path.GetDirectoryName(Environment.ProcessPath!)!, "artifacts"))

src/common/EventHandlerList`1.cs

@@ -49,7 +49,7 @@ public readonly void Raise<TState>(TState state, Action<T, TState> raiser)
                         }
                         catch (Exception ex)
                         {
-                            (exceptions ??= new()).Add(ex);
+                            (exceptions ??= []).Add(ex);
                         }
                     }
 

src/generators/Semantics/SemanticTreeGenerator.cs

@@ -28,7 +28,7 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
 
                 var baseName = Path.GetFileName(file.Path);
 
-                foreach (var type in root.Types ?? Array.Empty<SemanticTreeType>())
+                foreach (var type in root.Types ?? [])
                     GenerateType(ctx, Path.ChangeExtension(baseName, $"{type.Name}Semantics.g.cs"), type);
             });
     }
@@ -72,7 +72,7 @@ private static void GenerateType(SourceProductionContext context, string name, S
             writer.WriteLine();
         }
 
-        var props = type.Properties ?? Array.Empty<SemanticTreeProperty>();
+        var props = type.Properties ?? [];
 
         foreach (var prop in props)
         {

src/generators/Syntax/SyntaxTreeGenerator.cs

@@ -28,7 +28,7 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
 
                 var baseName = Path.GetFileName(file.Path);
 
-                foreach (var type in root.Types ?? Array.Empty<SyntaxTreeType>())
+                foreach (var type in root.Types ?? [])
                     GenerateType(ctx, Path.ChangeExtension(baseName, $"{type.Name}Syntax.g.cs"), type);
             });
     }
@@ -65,7 +65,7 @@ private static void GenerateType(SourceProductionContext context, string name, S
             writer.WriteLine();
         }
 
-        var props = type.Properties ?? Array.Empty<SyntaxTreeProperty>();
+        var props = type.Properties ?? [];
 
         foreach (var prop in props)
         {

src/language/core/Quality/LintPass.cs

@@ -6,12 +6,13 @@ namespace Vezel.Celerity.Language.Quality;
 public abstract class LintPass
 {
     public static ImmutableArray<LintPass> DefaultPasses { get; } =
-        ImmutableArray.Create<LintPass>(
+        [
             TestWithoutAssertPass.Instance,
             UndocumentedPublicSymbolPass.Instance,
             UnreachableCodePass.Instance,
             UnusedLocalSymbolPass.Instance,
-            UppercaseBaseIndicatorPass.Instance);
+            UppercaseBaseIndicatorPass.Instance
+        ];
 
     public DiagnosticCode Code { get; }
 

src/language/core/Semantics/Binding/LambdaScope.cs

@@ -7,7 +7,7 @@ internal sealed class LambdaScope : FunctionScope, IScope<LambdaScope>
     public ImmutableArray<ThisExpressionSemantics>.Builder ThisExpressions { get; } =
         ImmutableArray.CreateBuilder<ThisExpressionSemantics>(0);
 
-    private readonly Dictionary<Symbol, UpvalueSymbol> _upvalues = new();
+    private readonly Dictionary<Symbol, UpvalueSymbol> _upvalues = [];
 
     private int _upvalueSlot;
 

src/language/core/Semantics/Binding/LocalSymbol.cs

@@ -14,13 +14,11 @@ public abstract class LocalSymbol : Symbol
 
     public override sealed ImmutableArray<AssignmentExpressionSemantics> Assignments => _assignments;
 
-    private ImmutableArray<SemanticNode> _bindings = ImmutableArray<SemanticNode>.Empty;
+    private ImmutableArray<SemanticNode> _bindings = [];
 
-    private ImmutableArray<IdentifierExpressionSemantics> _references =
-        ImmutableArray<IdentifierExpressionSemantics>.Empty;
+    private ImmutableArray<IdentifierExpressionSemantics> _references = [];
 
-    private ImmutableArray<AssignmentExpressionSemantics> _assignments =
-        ImmutableArray<AssignmentExpressionSemantics>.Empty;
+    private ImmutableArray<AssignmentExpressionSemantics> _assignments = [];
 
     private protected LocalSymbol(string name)
     {

src/language/core/Semantics/Binding/Scope.cs

@@ -6,7 +6,7 @@ internal class Scope : IScope<Scope>
 {
     public Scope? Parent { get; }
 
-    private readonly Dictionary<string, Symbol> _symbols = new();
+    private readonly Dictionary<string, Symbol> _symbols = [];
 
     protected internal Scope(Scope? parent)
     {

src/language/core/Semantics/LanguageAnalyzer.cs

@@ -36,12 +36,11 @@ public void Dispose()
 
         private readonly ImmutableArray<Diagnostic>.Builder _diagnostics;
 
-        private readonly Dictionary<string, (List<UseDeclarationSemantics> Declarations, ModulePath? Path)> _uses =
-            new();
+        private readonly Dictionary<string, (List<UseDeclarationSemantics> Declarations, ModulePath? Path)> _uses = [];
 
-        private readonly List<IdentifierExpressionSemantics> _identifiers = new();
+        private readonly List<IdentifierExpressionSemantics> _identifiers = [];
 
-        private readonly HashSet<Symbol> _duplicates = new();
+        private readonly HashSet<Symbol> _duplicates = [];
 
         private Scope _scope = new(null);
 
@@ -183,7 +182,7 @@ private SemanticNodeList<TSemantics, TSyntax> ConvertList<TSyntax, TSemantics>(
             where TSemantics : SemanticNode
         {
             if (syntax.Count == 0)
-                return new(syntax, ImmutableArray<TSemantics>.Empty);
+                return new(syntax, []);
 
             var builder = Builder<TSemantics>(syntax.Count);
 
@@ -251,7 +250,7 @@ value is ReadOnlyMemory<byte> utf8 &&
                         $"Value for standard attribute '{name}' must be a {valueMsg}");
 
                 if (!allowMultiple)
-                    (CollectionsMarshal.GetValueRefOrAddDefault(grouped, name, out _) ??= new()).Add(attr);
+                    (CollectionsMarshal.GetValueRefOrAddDefault(grouped, name, out _) ??= []).Add(attr);
             }
 
             foreach (var (name, list) in grouped.OrderBy(static kvp => kvp.Key))
@@ -273,7 +272,7 @@ private SeparatedSemanticNodeList<TSemantics, TSyntax> ConvertList<TSyntax, TSem
             var elements = syntax.Elements;
 
             if (elements.Length == 0)
-                return new(syntax, ImmutableArray<TSemantics>.Empty);
+                return new(syntax, []);
 
             var builder = Builder<TSemantics>(elements.Length);
 
@@ -298,7 +297,7 @@ private void CheckDuplicateFields<TSemantics, TSyntax>(
 
             foreach (var field in fields)
                 if (selector(field) is { IsMissing: false } name)
-                    (CollectionsMarshal.GetValueRefOrAddDefault(map, name.Text, out _) ??= new()).Add(name.Span);
+                    (CollectionsMarshal.GetValueRefOrAddDefault(map, name.Text, out _) ??= []).Add(name.Span);
 
             foreach (var (name, spans) in map)
                 if (spans.Count != 1)
@@ -412,7 +411,7 @@ public override UseDeclarationSemantics VisitUseDeclaration(UseDeclarationSyntax
                 ref var entry = ref CollectionsMarshal.GetValueRefOrAddDefault(_uses, name.Text, out var exists);
 
                 if (!exists)
-                    entry = (new(), path);
+                    entry = ([], path);
 
                 entry.Declarations.Add(sema);
             }
@@ -1140,9 +1139,7 @@ public override CallExpressionSemantics VisitCallExpression(CallExpressionSyntax
         {
             var subject = VisitExpression(node.Subject);
             var args = ConvertList(node.ArgumentList.Arguments, static (@this, arg) => @this.VisitExpression(arg));
-            var defers = node.QuestionToken != null
-                ? _scope.CollectDefers(null)
-                : ImmutableArray<DeferStatementSemantics>.Empty;
+            var defers = node.QuestionToken != null ? _scope.CollectDefers(null) : [];
 
             var sema = new CallExpressionSemantics(node, subject, args, defers);
 

src/language/core/Syntax/LanguageLexer.cs

@@ -22,7 +22,7 @@ internal sealed class LanguageLexer
 
     private readonly StringBuilder _token = new();
 
-    private readonly List<char> _string = new();
+    private readonly List<char> _string = [];
 
     private readonly StringBuilder _closingIndentation = new();
 
@@ -81,14 +81,7 @@ private void Error(int position, DiagnosticCode code, string message)
 
     private void Error(int position, int length, DiagnosticCode code, string message)
     {
-        _diagnostics.Add(
-            tree => new(
-                tree,
-                new(position, length),
-                DiagnosticSeverity.Error,
-                code,
-                message,
-                ImmutableArray<DiagnosticNote>.Empty));
+        _diagnostics.Add(tree => new(tree, new(position, length), DiagnosticSeverity.Error, code, message, []));
 
         _errors = true;
     }