[IMP] core: make packaging optional

We don't want to add a requirement on packaging since it is not needed
to run odoo by default. It should be only useful when defining a more
"complex" external dependency (with version or markers)

Also solve an issue with google auth adding a filter warning

On google-auth import, setuptools will emit a warning in ubuntu noble
when importing pkg_resources.

This was not visible before the previous commits because another import
of pkg_resources was made before enabling the warnings.

The pkg_resources import is removed in google-auth >= 1.23.0 but
the noble version is 1.5.1 (as it was in jammy)

closes odoo#181768

Signed-off-by: Xavier Dollé (xdo) <[email protected]>

Author: Xavier-Do

odoo/modules/module.py

@@ -15,13 +15,26 @@
 import warnings
 from os.path import join as opj, normpath
 
-from packaging.requirements import InvalidRequirement, Requirement
-
 import odoo
 import odoo.tools as tools
 import odoo.release as release
 from odoo.tools.misc import file_path
 
+try:
+    from packaging.requirements import InvalidRequirement, Requirement
+except ImportError:
+    class InvalidRequirement(Exception):
+        ...
+
+    class Requirement:
+        def __init__(self, pydep):
+            if not re.fullmatch(r'\w+', pydep):  # check that we have no versions or marker in pydep
+                msg = f"Package `packaging` is required to parse `{pydep}` external dependency and is not installed"
+                raise Exception(msg)
+            self.marker = None
+            self.specifier = None
+            self.name = pydep
+
 
 MANIFEST_NAMES = ('__manifest__.py', '__openerp__.py')
 README = ['README.rst', 'README.md', 'README.txt']
@@ -467,9 +480,17 @@ def check_python_external_dependency(pydep):
             "Ignored external dependency %s because environment markers do not match",
             pydep
         )
+        return
     try:
         version = importlib.metadata.version(requirement.name)
     except importlib.metadata.PackageNotFoundError as e:
+        try:
+            # keep compatibility with module name but log a warning instead of info
+            importlib.import_module(pydep)
+            _logger.warning("python external dependency on '%s' does not appear o be a valid PyPI package. Using a PyPI package name is recommended.", pydep)
+            return
+        except ImportError:
+            pass
         msg = f"External dependency {pydep} not installed: {e}"
         raise Exception(msg) from e
     if requirement.specifier and not requirement.specifier.contains(version):

odoo/netsvc.py

@@ -197,6 +197,13 @@ def init_logger():
     # need to be adapted later but too muchwork for this pr.
     warnings.filterwarnings('ignore', r'^datetime.datetime.utcnow\(\) is deprecated and scheduled for removal in a future version.*', category=DeprecationWarning)
 
+    # pkg_ressouce is used in google-auth < 1.23.0 (removed in https://github.com/googleapis/google-auth-library-python/pull/596)
+    # unfortunately, in ubuntu jammy and noble, the google-auth version is 1.5.1
+    # starting from noble, the default pkg_ressource version emits a warning on import, triggered when importing
+    # google-auth
+    warnings.filterwarnings('ignore', r'pkg_resources is deprecated as an API.+', category=DeprecationWarning)
+    warnings.filterwarnings('ignore', r'Deprecated call to \`pkg_resources.declare_namespace.+', category=DeprecationWarning)
+
     from .tools.translate import resetlocale
     resetlocale()
 

requirements.txt

@@ -41,7 +41,6 @@ num2words==0.5.13 ; python_version >= '3.12'
 ofxparse==0.21
 openpyxl==3.0.9 ; python_version < '3.12'
 openpyxl==3.1.2 ; python_version >= '3.12'
-packaging==24.0
 passlib==1.7.4 # min version = 1.7.2 (Focal with security backports)
 Pillow==9.0.1 ; python_version <= '3.10'
 Pillow==9.4.0 ; python_version > '3.10' and python_version < '3.12'

setup.py

@@ -41,7 +41,6 @@
         'num2words',
         'ofxparse',
         'openpyxl',
-        'packaging',
         'passlib',
         'pillow',  # windows binary http://www.lfd.uci.edu/~gohlke/pythonlibs/
         'polib',