Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay templates are ignored #5

Open
Licenser opened this issue Feb 20, 2016 · 4 comments
Open

overlay templates are ignored #5

Licenser opened this issue Feb 20, 2016 · 4 comments

Comments

@Licenser
Copy link
Contributor

when running the cuttlefish plugin it is spoosed to not copy files that are already copied by the overlay, however that is not the case.

The problem is in here: https://github.com/tsloughter/rebar3_cuttlefish/blob/master/src/rebar3_cuttlefish_release.erl#L94-L95

Overlays uses relative a path like "apps/howl/priv/howl.schema" however the Schemas are absolute given a paths like "/Users/heinz/Projects/fifo/core/howl/apps/howl/priv/howl.schema"

@Licenser
Copy link
Contributor Author

Upon further investigation there is another issue for this namely it is here:

https://github.com/tsloughter/rebar3_cuttlefish/blob/master/src/rebar3_cuttlefish_release.erl#L50-L55

this tries to generate the config file based on the overlays found, not the one generated after the overlay.

I know this will require some re-writing but I think the file needs to be generated after relx has run and based on the final .schema files.

The issue here boing that cuttlefish does not allow having substitutions in the schema files.

@tsloughter
Copy link
Collaborator

@Licenser what about now that the generated conf file is templated: https://github.com/tsloughter/rebar3_cuttlefish/blob/master/src/rebar3_cuttlefish_release.erl#L63

@Licenser
Copy link
Contributor Author

Won't help, the problem is that the cuttlefish schema files contain placeholders, which can't be parsed as they are not valid cuttlefish syntax so the line before L62 crashes.

@tsloughter
Copy link
Collaborator

That doesn't make sense, I could have swore that is how cuttlefish worked with rebar2/nodepackage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants