-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overlay templates are ignored #5
Comments
Upon further investigation there is another issue for this namely it is here: this tries to generate the config file based on the overlays found, not the one generated after the overlay. I know this will require some re-writing but I think the file needs to be generated after relx has run and based on the final .schema files. The issue here boing that cuttlefish does not allow having substitutions in the schema files. |
@Licenser what about now that the generated conf file is templated: https://github.com/tsloughter/rebar3_cuttlefish/blob/master/src/rebar3_cuttlefish_release.erl#L63 |
Won't help, the problem is that the cuttlefish schema files contain placeholders, which can't be parsed as they are not valid cuttlefish syntax so the line before L62 crashes. |
That doesn't make sense, I could have swore that is how cuttlefish worked with rebar2/nodepackage. |
when running the cuttlefish plugin it is spoosed to not copy files that are already copied by the overlay, however that is not the case.
The problem is in here: https://github.com/tsloughter/rebar3_cuttlefish/blob/master/src/rebar3_cuttlefish_release.erl#L94-L95
Overlays
uses relative a path like"apps/howl/priv/howl.schema"
however theSchemas
are absolute given a paths like"/Users/heinz/Projects/fifo/core/howl/apps/howl/priv/howl.schema"
The text was updated successfully, but these errors were encountered: