Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending fatal alert BadCertificate #8626

Open
1 task done
gerardo-lima-moonfare opened this issue Jun 28, 2024 · 7 comments
Open
1 task done

Sending fatal alert BadCertificate #8626

gerardo-lima-moonfare opened this issue Jun 28, 2024 · 7 comments
Labels
kind: bug Something isn't working owned-by: turborepo

Comments

@gerardo-lima-moonfare
Copy link

Verify canary release

  • I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue

https://gist.github.com/gerardo-lima-moonfare/b8b75ea2337d8662edaf7d2a8ae5a599

What package manager are you using / does the bug impact?

npm

What operating system are you using?

Mac

Which canary version will you have in your reproduction?

[email protected]

Describe the Bug

The following message is shown in many situations:
WARNING Sending fatal alert BadCertificate

Expected Behavior

No message about BadCertificate.

To Reproduce

npm install turbo@canary -g
turbo completion bash > /dev/null

shows: WARNING Sending fatal alert BadCertificate

Additional context

I use self-signed certificates.

@gerardo-lima-moonfare gerardo-lima-moonfare added kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Jun 28, 2024
@chris-olszewski
Copy link
Member

Is the issue just that the warning is noisy or is it preventing usage of the remote cache?

@gerardo-lima-moonfare
Copy link
Author

hey, @chris-olszewski, I'm not using remote cache, so I'm not sure. Either way, a bad certificate error is enough to make some security folks worried. Is there a way to avoid it?

@chris-olszewski
Copy link
Member

You could try turbo telemetry disable

@chris-olszewski chris-olszewski removed the needs: triage New issues get this label. Remove it after triage label Jul 2, 2024
@gerardo-lima-moonfare
Copy link
Author

Thank you, @chris-olszewski, the message is gone 🎉 I believe, though, I'll have the same issues if/when I start using remote cache. I checked some web references and this seems to be related to a Rust library that does not use system certificates. I hope this might be useful to other people. cheers

@chris-olszewski
Copy link
Member

We should already be including system certificates. I think the issue might be that there's a certificate being used that the HTTP client doesn't approve of. Still haven't found where in the stack this warning is getting thrown.

@gerardo-lima-moonfare
Copy link
Author

The message itself comes from a Rust library, as I found it in a plain Rust context, unrelated to turborepo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working owned-by: turborepo
Projects
None yet
Development

No branches or pull requests

2 participants