Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxDuration does not work for remix + vite #96

Open
lifeiscontent opened this issue Mar 21, 2024 · 13 comments
Open

maxDuration does not work for remix + vite #96

lifeiscontent opened this issue Mar 21, 2024 · 13 comments

Comments

@lifeiscontent
Copy link

following the docs using the export const config = { ... } as well as the vercel.json fails to deploy for me

https://vercel.com/docs/functions/configuring-functions/duration

@lifeiscontent
Copy link
Author

@TooTallNate any ideas here? we're having a ton of traffic on our site today and would really like to increase this 😅

@TooTallNate
Copy link
Member

Can you elaborate on "fails to deploy"? What are you seeing? Can you share a reproduction, or a deployment URL?

@lifeiscontent
Copy link
Author

@TooTallNate
Copy link
Member

Ok, so ya, you don't configure maxDuration for Remix routes using vercel.json. Do it the export const config = { ... } way like described in the Remix on Vercel docs page.

@lifeiscontent
Copy link
Author

@TooTallNate I tried that as well, and the build wouldn't even compile, complained about something to do with some files in node modules already existing. let me revert to that commit and send over a URL

@lifeiscontent
Copy link
Author

@TooTallNate
Copy link
Member

This error seems unrelated to the export const config part, but did you see this issue which looks similar? remix-run#8813

@lifeiscontent
Copy link
Author

Screenshot 2024-03-21 at 1 50 18 PM
this is the entire diff, removing it fixes the build

@lifeiscontent
Copy link
Author

@TooTallNate ^

@lifeiscontent
Copy link
Author

interestingly enough, adding the config to root.tsx does not break the build

@TooTallNate
Copy link
Member

That is strange. I will relay that to the Remix team. If you could give a standalone reproduction that would help as well.

@lifeiscontent
Copy link
Author

I'll see what I can do, thanks!

@TooTallNate
Copy link
Member

Ya that would be helpful. I wasn't able to reproduce using the vc init remix template, and changing the config of both of those routes in the template to have export const config = { maxDuration: 30 } worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants