Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace println! with log functions (info!, warn!, etc) #503

Open
gbryant-arm opened this issue Aug 9, 2022 · 3 comments
Open

Replace println! with log functions (info!, warn!, etc) #503

gbryant-arm opened this issue Aug 9, 2022 · 3 comments
Labels
enhancement New feature or request trusted-veracruz-runtime Something related to the trusted Veracruz runtime

Comments

@gbryant-arm
Copy link
Contributor

gbryant-arm commented Aug 9, 2022

Requested feature
Replace println! with log functions (info!, warn!, etc).
Use debug! for dumping debugging material, e.g. in https://github.com/veracruz-project/veracruz/blob/main/runtime-manager/src/platforms/linux.rs#L261

Motivation
println! is still used extensively, especially in the Runtime Manager. This degrades performance and is potentially dangerous

@gbryant-arm gbryant-arm added enhancement New feature or request trusted-veracruz-runtime Something related to the trusted Veracruz runtime labels Aug 9, 2022
@dreemkiller
Copy link
Member

@gbryant-arm how's the status on this? I think it's complete, but can't be sure

@gbryant-arm
Copy link
Contributor Author

When running VOD with log level set to info, I'm getting a log over 15K lines.
I'd suggest we replace info! with debug! or trace! for most debug messages that keep showing up. Cf. tls_data() and read_tls_data() in veracruz-server/src/platforms/linux.rs

@mathias-arm
Copy link
Contributor

I only see 3 places left:

The last two seem to be essentially dead code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request trusted-veracruz-runtime Something related to the trusted Veracruz runtime
Projects
None yet
Development

No branches or pull requests

3 participants