diff --git a/lib/codecs/src/decoding/framing/chunked_gelf.rs b/lib/codecs/src/decoding/framing/chunked_gelf.rs index b5a67b7aec5ba..286645cfa5698 100644 --- a/lib/codecs/src/decoding/framing/chunked_gelf.rs +++ b/lib/codecs/src/decoding/framing/chunked_gelf.rs @@ -387,7 +387,6 @@ impl ChunkedGelfDecoder { warn!( message_id = message_id, timeout_secs = timeout.as_secs_f64(), - internal_log_rate_limit = true, "Message was not fully received within the timeout window. Discarding it." ); } @@ -409,7 +408,6 @@ impl ChunkedGelfDecoder { debug!( message_id = message_id, sequence_number = sequence_number, - internal_log_rate_limit = true, "Received a duplicate chunk. Ignoring it." ); return Ok(None); diff --git a/lib/dnstap-parser/src/internal_events.rs b/lib/dnstap-parser/src/internal_events.rs index ab1635c9b3e03..2ce75acb19709 100644 --- a/lib/dnstap-parser/src/internal_events.rs +++ b/lib/dnstap-parser/src/internal_events.rs @@ -14,7 +14,7 @@ impl InternalEvent for DnstapParseWarning { error = %self.error, stage = error_stage::PROCESSING, error_type = error_type::PARSER_FAILED, - internal_log_rate_limit = true, + ); } } diff --git a/lib/tracing-limit/benches/limit.rs b/lib/tracing-limit/benches/limit.rs index f7214525e9819..86ffbae5bf206 100644 --- a/lib/tracing-limit/benches/limit.rs +++ b/lib/tracing-limit/benches/limit.rs @@ -59,7 +59,6 @@ fn bench(c: &mut Criterion) { bar = "bar", baz = 3, quuux = ?0.99, - internal_log_rate_limit = true ) } }) diff --git a/lib/tracing-limit/examples/basic.rs b/lib/tracing-limit/examples/basic.rs index 3b4428d540997..86c973739b13a 100644 --- a/lib/tracing-limit/examples/basic.rs +++ b/lib/tracing-limit/examples/basic.rs @@ -14,11 +14,7 @@ fn main() { tracing::dispatcher::with_default(&dispatch, || { for i in 0..40usize { trace!("This field is not rate limited!"); - info!( - message = "This message is rate limited", - count = &i, - internal_log_rate_limit = true, - ); + info!(message = "This message is rate limited", count = &i,); std::thread::sleep(std::time::Duration::from_millis(1000)); } }) diff --git a/lib/tracing-limit/examples/by_span.rs b/lib/tracing-limit/examples/by_span.rs index 63b8775d9905d..0c7e81666d279 100644 --- a/lib/tracing-limit/examples/by_span.rs +++ b/lib/tracing-limit/examples/by_span.rs @@ -28,7 +28,6 @@ fn main() { message = "This message is rate limited by its component and vrl_line_number", count = &i, - internal_log_rate_limit = true, ); } } diff --git a/lib/tracing-limit/src/lib.rs b/lib/tracing-limit/src/lib.rs index bd5952bf39760..dc131b3e31b39 100644 --- a/lib/tracing-limit/src/lib.rs +++ b/lib/tracing-limit/src/lib.rs @@ -129,7 +129,7 @@ where let mut limit_visitor = LimitVisitor::default(); event.record(&mut limit_visitor); - let limit_exists = limit_visitor.limit.unwrap_or(false); + let limit_exists = limit_visitor.limit.unwrap_or(true); if !limit_exists { return self.inner.on_event(event, ctx); } @@ -264,11 +264,8 @@ where let valueset = fields.value_set(&values); let event = Event::new(metadata, &valueset); self.inner.on_event(&event, ctx.clone()); - } else { - let values = [( - &fields.field(RATE_LIMIT_FIELD).unwrap(), - Some(&rate_limit as &dyn Value), - )]; + } else if let Some(ratelimit_field) = fields.field(RATE_LIMIT_FIELD) { + let values = [(&ratelimit_field, Some(&rate_limit as &dyn Value))]; let valueset = fields.value_set(&values); let event = Event::new(metadata, &valueset); @@ -525,6 +522,34 @@ mod test { ); } + #[test] + fn rate_limits_default() { + let events: Arc>> = Default::default(); + + let recorder = RecordingLayer::new(Arc::clone(&events)); + let sub = tracing_subscriber::registry::Registry::default() + .with(RateLimitedLayer::new(recorder).with_default_limit(10)); + tracing::subscriber::with_default(sub, || { + for _ in 0..21 { + info!(message = "Hello world!"); + MockClock::advance(Duration::from_millis(100)); + } + }); + + let events = events.lock().unwrap(); + + assert_eq!( + *events, + vec![ + "Hello world!", + "Internal log [Hello world!] is being suppressed to avoid flooding.", + ] + .into_iter() + .map(std::borrow::ToOwned::to_owned) + .collect::>() + ); + } + #[test] fn override_rate_limit_at_callsite() { let events: Arc>> = Default::default(); @@ -534,11 +559,7 @@ mod test { .with(RateLimitedLayer::new(recorder).with_default_limit(100)); tracing::subscriber::with_default(sub, || { for _ in 0..21 { - info!( - message = "Hello world!", - internal_log_rate_limit = true, - internal_log_rate_secs = 1 - ); + info!(message = "Hello world!", internal_log_rate_secs = 1); MockClock::advance(Duration::from_millis(100)); } }); @@ -579,7 +600,6 @@ mod test { info!( message = format!("Hello {} on line_number {}!", key, line_number).as_str(), - internal_log_rate_limit = true ); } } @@ -641,7 +661,6 @@ mod test { info!( message = format!("Hello {} on line_number {}!", key, line_number).as_str(), - internal_log_rate_limit = true, component_id = &key, vrl_position = &line_number ); diff --git a/lib/vector-buffers/src/internal_events.rs b/lib/vector-buffers/src/internal_events.rs index 0cda5beec46f9..055f09ebb6e62 100644 --- a/lib/vector-buffers/src/internal_events.rs +++ b/lib/vector-buffers/src/internal_events.rs @@ -115,7 +115,7 @@ impl InternalEvent for BufferReadError { error_code = self.error_code, error_type = error_type::READER_FAILED, stage = "processing", - internal_log_rate_limit = true, + ); counter!( "buffer_errors_total", "error_code" => self.error_code, diff --git a/lib/vector-common/src/internal_event/component_events_dropped.rs b/lib/vector-common/src/internal_event/component_events_dropped.rs index c7d2bd9eedd32..f8838911ff8a0 100644 --- a/lib/vector-common/src/internal_event/component_events_dropped.rs +++ b/lib/vector-common/src/internal_event/component_events_dropped.rs @@ -58,7 +58,6 @@ impl InternalEventHandle for DroppedHandle<'_, INTENDED> { intentional = INTENDED, count = data.0, reason = self.reason, - internal_log_rate_limit = true, ); } else { error!( @@ -66,7 +65,6 @@ impl InternalEventHandle for DroppedHandle<'_, INTENDED> { intentional = INTENDED, count = data.0, reason = self.reason, - internal_log_rate_limit = true, ); } self.discarded_events.increment(data.0 as u64); diff --git a/lib/vector-common/src/internal_event/service.rs b/lib/vector-common/src/internal_event/service.rs index 20132cc99fc61..d6c912f9d3fbc 100644 --- a/lib/vector-common/src/internal_event/service.rs +++ b/lib/vector-common/src/internal_event/service.rs @@ -14,7 +14,6 @@ impl InternalEvent for PollReadyError { error = ?self.error, error_type = error_type::REQUEST_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", @@ -45,7 +44,7 @@ impl InternalEvent for CallError { request_id = self.request_id, error_type = error_type::REQUEST_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/app.rs b/src/app.rs index 283ba707c8ae9..d6925d76eeb66 100644 --- a/src/app.rs +++ b/src/app.rs @@ -585,10 +585,7 @@ pub fn init_logging(color: bool, format: LogFormat, log_level: &str, rate: u64) }; trace::init(color, json, &level, rate); - debug!( - message = "Internal log rate limit configured.", - internal_log_rate_secs = rate, - ); + debug!(message = "Internal log rate limit configured.",); info!(message = "Log level is enabled.", level = ?level); } diff --git a/src/cli.rs b/src/cli.rs index 279560154585c..93e1dfea4d6bd 100644 --- a/src/cli.rs +++ b/src/cli.rs @@ -178,6 +178,7 @@ pub struct RootOpts { pub watch_config_poll_interval_seconds: NonZeroU64, /// Set the internal log rate limit + /// Note that traces are throttled by default unless tagged with `internal_log_rate_limit = false`. #[arg( short, long, diff --git a/src/internal_events/amqp.rs b/src/internal_events/amqp.rs index c66a3d9087016..677ec605ea234 100644 --- a/src/internal_events/amqp.rs +++ b/src/internal_events/amqp.rs @@ -36,7 +36,7 @@ pub mod source { error = ?self.error, error_type = error_type::REQUEST_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -58,7 +58,7 @@ pub mod source { error = ?self.error, error_type = error_type::ACKNOWLEDGMENT_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -80,7 +80,7 @@ pub mod source { error = ?self.error, error_type = error_type::COMMAND_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/apache_metrics.rs b/src/internal_events/apache_metrics.rs index 79ae7dced79b4..849741e44dd41 100644 --- a/src/internal_events/apache_metrics.rs +++ b/src/internal_events/apache_metrics.rs @@ -46,7 +46,7 @@ impl InternalEvent for ApacheMetricsParseError<'_> { stage = error_stage::PROCESSING, error_type = error_type::PARSER_FAILED, endpoint = %self.endpoint, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/aws_cloudwatch_logs.rs b/src/internal_events/aws_cloudwatch_logs.rs index d4bfe0328a53b..d8c4838dab7e1 100644 --- a/src/internal_events/aws_cloudwatch_logs.rs +++ b/src/internal_events/aws_cloudwatch_logs.rs @@ -18,7 +18,6 @@ impl InternalEvent for AwsCloudwatchLogsMessageSizeError { error_code = "message_too_long", error_type = error_type::ENCODER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", diff --git a/src/internal_events/aws_ec2_metadata.rs b/src/internal_events/aws_ec2_metadata.rs index 3e0996a3c9f60..3eafadf20222d 100644 --- a/src/internal_events/aws_ec2_metadata.rs +++ b/src/internal_events/aws_ec2_metadata.rs @@ -24,7 +24,7 @@ impl InternalEvent for AwsEc2MetadataRefreshError { error = %self.error, error_type = error_type::REQUEST_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/aws_ecs_metrics.rs b/src/internal_events/aws_ecs_metrics.rs index 1a2f7133094ce..969c5c33aa2e6 100644 --- a/src/internal_events/aws_ecs_metrics.rs +++ b/src/internal_events/aws_ecs_metrics.rs @@ -50,12 +50,12 @@ impl InternalEvent for AwsEcsMetricsParseError<'_> { error = ?self.error, stage = error_stage::PROCESSING, error_type = error_type::PARSER_FAILED, - internal_log_rate_limit = true, + ); debug!( message = %format!("Failed to parse response:\\n\\n{}\\n\\n", self.body.escape_debug()), endpoint = %self.endpoint, - internal_log_rate_limit = true, + ); counter!("parse_errors_total").increment(1); counter!( diff --git a/src/internal_events/aws_kinesis.rs b/src/internal_events/aws_kinesis.rs index 332f55d08b25e..fd5f73bb7e11f 100644 --- a/src/internal_events/aws_kinesis.rs +++ b/src/internal_events/aws_kinesis.rs @@ -17,7 +17,7 @@ impl InternalEvent for AwsKinesisStreamNoPartitionKeyError<'_> { partition_key_field = %self.partition_key_field, error_type = error_type::PARSER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( diff --git a/src/internal_events/aws_kinesis_firehose.rs b/src/internal_events/aws_kinesis_firehose.rs index d98d5ed5fa1c4..317435696b799 100644 --- a/src/internal_events/aws_kinesis_firehose.rs +++ b/src/internal_events/aws_kinesis_firehose.rs @@ -48,7 +48,6 @@ impl InternalEvent for AwsKinesisFirehoseRequestError<'_> { error_type = error_type::REQUEST_FAILED, error_code = %self.error_code, request_id = %self.request_id.unwrap_or(""), - internal_log_rate_limit = true, ); counter!( "component_errors_total", @@ -75,7 +74,7 @@ impl InternalEvent for AwsKinesisFirehoseAutomaticRecordDecodeError { error_type = error_type::PARSER_FAILED, error_code = %io_error_code(&self.error), compression = %self.compression, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/aws_sqs.rs b/src/internal_events/aws_sqs.rs index 2de4fd7f74197..06c658fc2c79a 100644 --- a/src/internal_events/aws_sqs.rs +++ b/src/internal_events/aws_sqs.rs @@ -29,7 +29,7 @@ mod s3 { error_code = "failed_processing_sqs_message", error_type = error_type::PARSER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -73,7 +73,7 @@ mod s3 { error_code = "failed_deleting_some_sqs_messages", error_type = error_type::ACKNOWLEDGMENT_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -103,7 +103,7 @@ mod s3 { error_code = "failed_deleting_all_sqs_messages", error_type = error_type::ACKNOWLEDGMENT_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -129,7 +129,7 @@ impl InternalEvent for SqsMessageReceiveError<'_, E> { error_code = "failed_fetching_sqs_events", error_type = error_type::REQUEST_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -182,7 +182,7 @@ impl InternalEvent for SqsMessageDeleteError<'_, E> { error = %self.error, error_type = error_type::WRITER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/batch.rs b/src/internal_events/batch.rs index 816afa4398d5f..5afc99d47f1bf 100644 --- a/src/internal_events/batch.rs +++ b/src/internal_events/batch.rs @@ -17,7 +17,7 @@ impl InternalEvent for LargeEventDroppedError { length = %self.length, error_type = error_type::CONDITION_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/codecs.rs b/src/internal_events/codecs.rs index 50251bf089cd3..e876db1dab5ab 100644 --- a/src/internal_events/codecs.rs +++ b/src/internal_events/codecs.rs @@ -15,7 +15,7 @@ impl InternalEvent for DecoderFramingError { error_code = "decoder_frame", error_type = error_type::PARSER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -40,7 +40,7 @@ impl InternalEvent for DecoderDeserializeError<'_> { error_code = "decoder_deserialize", error_type = error_type::PARSER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -66,7 +66,7 @@ impl InternalEvent for EncoderFramingError<'_> { error_code = "encoder_frame", error_type = error_type::ENCODER_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -93,7 +93,7 @@ impl InternalEvent for EncoderSerializeError<'_> { error_code = "encoder_serialize", error_type = error_type::ENCODER_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -120,7 +120,7 @@ impl InternalEvent for EncoderWriteError<'_, E> { error = %self.error, error_type = error_type::IO_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/common.rs b/src/internal_events/common.rs index 78971840d7dba..f342710daedb2 100644 --- a/src/internal_events/common.rs +++ b/src/internal_events/common.rs @@ -66,7 +66,7 @@ impl InternalEvent for SocketOutgoingConnectionError { error_code = "failed_connecting", error_type = error_type::CONNECTION_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -92,7 +92,6 @@ impl InternalEvent for StreamClosedError { error_code = STREAM_CLOSED, error_type = error_type::WRITER_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", @@ -137,7 +136,7 @@ impl InternalEvent for SinkRequestBuildError { error = %self.error, error_type = error_type::ENCODER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/conditions.rs b/src/internal_events/conditions.rs index bf825213c6719..0f7cb70962b08 100644 --- a/src/internal_events/conditions.rs +++ b/src/internal_events/conditions.rs @@ -14,7 +14,6 @@ impl InternalEvent for VrlConditionExecutionError<'_> { error = %self.error, error_type = error_type::SCRIPT_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", diff --git a/src/internal_events/datadog_agent.rs b/src/internal_events/datadog_agent.rs index 02f017bc076bb..686e3e0e3179c 100644 --- a/src/internal_events/datadog_agent.rs +++ b/src/internal_events/datadog_agent.rs @@ -15,7 +15,7 @@ impl InternalEvent for DatadogAgentJsonParseError<'_> { error = ?self.error, error_type = error_type::PARSER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/datadog_metrics.rs b/src/internal_events/datadog_metrics.rs index 8875b29281ac7..03812c2c81def 100644 --- a/src/internal_events/datadog_metrics.rs +++ b/src/internal_events/datadog_metrics.rs @@ -17,7 +17,6 @@ impl InternalEvent for DatadogMetricsEncodingError<'_> { error_type = error_type::ENCODER_FAILED, intentional = "false", stage = error_stage::PROCESSING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", diff --git a/src/internal_events/datadog_traces.rs b/src/internal_events/datadog_traces.rs index dd1df213cdf06..aee946528391b 100644 --- a/src/internal_events/datadog_traces.rs +++ b/src/internal_events/datadog_traces.rs @@ -18,7 +18,7 @@ impl InternalEvent for DatadogTracesEncodingError { error_reason = %self.error_reason, error_type = error_type::ENCODER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -48,7 +48,7 @@ impl InternalEvent for DatadogTracesAPMStatsError { error = %self.error, error_type = error_type::WRITER_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/dnstap.rs b/src/internal_events/dnstap.rs index 231a6527830d7..adf9ea8688d6c 100644 --- a/src/internal_events/dnstap.rs +++ b/src/internal_events/dnstap.rs @@ -14,7 +14,7 @@ impl InternalEvent for DnstapParseError { error = %self.error, stage = error_stage::PROCESSING, error_type = error_type::PARSER_FAILED, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/docker_logs.rs b/src/internal_events/docker_logs.rs index 81950b1fa947a..f1daaa6c2d4f4 100644 --- a/src/internal_events/docker_logs.rs +++ b/src/internal_events/docker_logs.rs @@ -170,7 +170,7 @@ impl InternalEvent for DockerLogsLoggingDriverUnsupportedError<'_> { error_type = error_type::CONFIGURATION_FAILED, stage = error_stage::RECEIVING, container_id = ?self.container_id, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/encoding_transcode.rs b/src/internal_events/encoding_transcode.rs index 0a377f52ca1ee..869423fb98241 100644 --- a/src/internal_events/encoding_transcode.rs +++ b/src/internal_events/encoding_transcode.rs @@ -27,7 +27,6 @@ impl InternalEvent for DecoderMalformedReplacement { warn!( message = "Replaced malformed sequences with replacement character while decoding to utf8.", from_encoding = %self.from_encoding, - internal_log_rate_limit = true ); // NOT the actual number of replacements in the output: there's no easy // way to get that from the lib we use here (encoding_rs) diff --git a/src/internal_events/eventstoredb_metrics.rs b/src/internal_events/eventstoredb_metrics.rs index b5d7fadd088dc..7ee7f36cf9f50 100644 --- a/src/internal_events/eventstoredb_metrics.rs +++ b/src/internal_events/eventstoredb_metrics.rs @@ -14,7 +14,7 @@ impl InternalEvent for EventStoreDbMetricsHttpError { error = ?self.error, stage = error_stage::RECEIVING, error_type = error_type::REQUEST_FAILED, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -37,7 +37,7 @@ impl InternalEvent for EventStoreDbStatsParsingError { error = ?self.error, stage = error_stage::PROCESSING, error_type = error_type::PARSER_FAILED, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/exec.rs b/src/internal_events/exec.rs index 539471719d0e9..3a5ffe7c1c9ef 100644 --- a/src/internal_events/exec.rs +++ b/src/internal_events/exec.rs @@ -53,7 +53,7 @@ impl InternalEvent for ExecFailedError<'_> { error_type = error_type::COMMAND_FAILED, error_code = %io_error_code(&self.error), stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -82,7 +82,7 @@ impl InternalEvent for ExecTimeoutError<'_> { error = %self.error, error_type = error_type::TIMED_OUT, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -118,7 +118,7 @@ impl InternalEvent for ExecCommandExecuted<'_> { command = %self.command, exit_status = %exit_status, elapsed_millis = %self.exec_duration.as_millis(), - internal_log_rate_limit = true, + ); counter!( "command_executed_total", @@ -194,7 +194,7 @@ impl InternalEvent for ExecFailedToSignalChildError<'_> { error_code = %self.error.to_error_code(), error_type = error_type::COMMAND_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -216,7 +216,6 @@ impl InternalEvent for ExecChannelClosedError { message = exec_reason, error_type = error_type::COMMAND_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", diff --git a/src/internal_events/file.rs b/src/internal_events/file.rs index fba86d6ad1b72..84cf828c89d7a 100644 --- a/src/internal_events/file.rs +++ b/src/internal_events/file.rs @@ -83,7 +83,6 @@ impl InternalEvent for FileIoError<'_, P> { error_code = %self.code, error_type = error_type::IO_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", @@ -222,7 +221,7 @@ mod source { error_code = "reading_fingerprint", error_type = error_type::READER_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); if self.include_file_metric_tag { counter!( @@ -262,7 +261,6 @@ mod source { error_code = DELETION_FAILED, error_type = error_type::COMMAND_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, ); if self.include_file_metric_tag { counter!( @@ -355,7 +353,7 @@ mod source { error_type = error_type::COMMAND_FAILED, stage = error_stage::RECEIVING, file = %self.file.display(), - internal_log_rate_limit = true, + ); if self.include_file_metric_tag { counter!( @@ -457,7 +455,7 @@ mod source { error_code = "writing_checkpoints", error_type = error_type::WRITER_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -484,7 +482,6 @@ mod source { error_type = error_type::READER_FAILED, stage = error_stage::RECEIVING, path = %self.path.display(), - internal_log_rate_limit = true, ); counter!( "component_errors_total", diff --git a/src/internal_events/fluent.rs b/src/internal_events/fluent.rs index 3493db9cd762d..aa0d26610b72a 100644 --- a/src/internal_events/fluent.rs +++ b/src/internal_events/fluent.rs @@ -30,7 +30,7 @@ impl InternalEvent for FluentMessageDecodeError<'_> { base64_encoded_message = %self.base64_encoded_message, error_type = error_type::PARSER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/gcp_pubsub.rs b/src/internal_events/gcp_pubsub.rs index 1f6a7b5253514..be3f274e8d225 100644 --- a/src/internal_events/gcp_pubsub.rs +++ b/src/internal_events/gcp_pubsub.rs @@ -14,7 +14,7 @@ impl InternalEvent for GcpPubsubConnectError { error_code = "failed_connecting", error_type = error_type::CONNECTION_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( @@ -39,7 +39,7 @@ impl InternalEvent for GcpPubsubStreamingPullError { error_code = "failed_streaming_pull", error_type = error_type::REQUEST_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( @@ -64,7 +64,7 @@ impl InternalEvent for GcpPubsubReceiveError { error_code = "failed_fetching_events", error_type = error_type::REQUEST_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( diff --git a/src/internal_events/host_metrics.rs b/src/internal_events/host_metrics.rs index 3352e529edf0a..56d5649159dfb 100644 --- a/src/internal_events/host_metrics.rs +++ b/src/internal_events/host_metrics.rs @@ -13,7 +13,6 @@ impl InternalEvent for HostMetricsScrapeError { message = self.message, error_type = error_type::READER_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, ); counter!( @@ -38,7 +37,7 @@ impl InternalEvent for HostMetricsScrapeDetailError { error = %self.error, error_type = error_type::READER_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( @@ -65,7 +64,7 @@ impl InternalEvent for HostMetricsScrapeFilesystemError { error = %self.error, error_type = error_type::READER_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( diff --git a/src/internal_events/http.rs b/src/internal_events/http.rs index b2b3bfec4ad95..5a1e818dcc484 100644 --- a/src/internal_events/http.rs +++ b/src/internal_events/http.rs @@ -127,7 +127,7 @@ impl InternalEvent for HttpBadRequest<'_> { error_type = error_type::REQUEST_FAILED, error_stage = error_stage::RECEIVING, http_code = %self.code, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/http_client.rs b/src/internal_events/http_client.rs index a6fde2f1a6dd1..155e9d8d67739 100644 --- a/src/internal_events/http_client.rs +++ b/src/internal_events/http_client.rs @@ -86,7 +86,7 @@ impl InternalEvent for GotHttpWarning<'_> { error = %self.error, error_type = error_type::REQUEST_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!("http_client_errors_total", "error_kind" => self.error.to_string()).increment(1); histogram!("http_client_rtt_seconds").record(self.roundtrip); diff --git a/src/internal_events/http_client_source.rs b/src/internal_events/http_client_source.rs index 376adf35eda56..ad1b989d3969a 100644 --- a/src/internal_events/http_client_source.rs +++ b/src/internal_events/http_client_source.rs @@ -49,7 +49,7 @@ impl InternalEvent for HttpClientHttpResponseError { stage = error_stage::RECEIVING, error_type = error_type::REQUEST_FAILED, error_code = %http_error_code(self.code.as_u16()), - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -76,7 +76,7 @@ impl InternalEvent for HttpClientHttpError { error = ?self.error, error_type = error_type::REQUEST_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/influxdb.rs b/src/internal_events/influxdb.rs index 007f5565f1a8f..d487353b8dc68 100644 --- a/src/internal_events/influxdb.rs +++ b/src/internal_events/influxdb.rs @@ -16,7 +16,6 @@ impl InternalEvent for InfluxdbEncodingError { error = %self.error_message, error_type = error_type::ENCODER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", diff --git a/src/internal_events/journald.rs b/src/internal_events/journald.rs index f467137186baa..9f7e9a694f9ca 100644 --- a/src/internal_events/journald.rs +++ b/src/internal_events/journald.rs @@ -17,7 +17,7 @@ impl InternalEvent for JournaldInvalidRecordError { text = %self.text, error_type = error_type::PARSER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -40,7 +40,7 @@ impl InternalEvent for JournaldStartJournalctlError { error = %self.error, error_type = error_type::COMMAND_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -63,7 +63,7 @@ impl InternalEvent for JournaldReadError { error = %self.error, error_type = error_type::READER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -88,7 +88,6 @@ impl InternalEvent for JournaldCheckpointSetError { error = %self.error, error_type = error_type::IO_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", @@ -113,7 +112,7 @@ impl InternalEvent for JournaldCheckpointFileOpenError { error = %self.error, error_type = error_type::IO_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/kafka.rs b/src/internal_events/kafka.rs index ea1b198be7053..05e06ea5161ff 100644 --- a/src/internal_events/kafka.rs +++ b/src/internal_events/kafka.rs @@ -78,7 +78,7 @@ impl InternalEvent for KafkaOffsetUpdateError { error_code = "kafka_offset_update", error_type = error_type::READER_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -103,7 +103,7 @@ impl InternalEvent for KafkaReadError { error_code = "reading_message", error_type = error_type::READER_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -163,7 +163,6 @@ impl InternalEvent for KafkaHeaderExtractionError<'_> { error_type = error_type::PARSER_FAILED, stage = error_stage::RECEIVING, header_field = self.header_field.to_string(), - internal_log_rate_limit = true, ); counter!( "component_errors_total", diff --git a/src/internal_events/kubernetes_logs.rs b/src/internal_events/kubernetes_logs.rs index 77dac30b1945b..e70f3f47cc4a7 100644 --- a/src/internal_events/kubernetes_logs.rs +++ b/src/internal_events/kubernetes_logs.rs @@ -70,7 +70,7 @@ impl InternalEvent for KubernetesLogsEventAnnotationError<'_> { error_code = ANNOTATION_FAILED, error_type = error_type::READER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -95,7 +95,7 @@ impl InternalEvent for KubernetesLogsEventNamespaceAnnotationError<'_> { error_code = ANNOTATION_FAILED, error_type = error_type::READER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -121,7 +121,7 @@ impl InternalEvent for KubernetesLogsEventNodeAnnotationError<'_> { error_code = ANNOTATION_FAILED, error_type = error_type::READER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -161,7 +161,7 @@ impl InternalEvent for KubernetesLogsDockerFormatParseError<'_> { error = %self.error, error_type = error_type::PARSER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -190,7 +190,7 @@ impl InternalEvent for KubernetesLifecycleError { error_code = KUBERNETES_LIFECYCLE, error_type = error_type::READER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/logplex.rs b/src/internal_events/logplex.rs index 160947fb0d147..b08df7c624d4f 100644 --- a/src/internal_events/logplex.rs +++ b/src/internal_events/logplex.rs @@ -36,7 +36,7 @@ impl InternalEvent for HerokuLogplexRequestReadError { error_type = error_type::READER_FAILED, error_code = io_error_code(&self.error), stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/loki.rs b/src/internal_events/loki.rs index 2c95d524c655f..6a5e7567b65b2 100644 --- a/src/internal_events/loki.rs +++ b/src/internal_events/loki.rs @@ -12,7 +12,6 @@ impl InternalEvent for LokiEventUnlabeledError { error_code = "unlabeled_event", error_type = error_type::CONDITION_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, ); counter!( @@ -39,7 +38,6 @@ impl InternalEvent for LokiOutOfOrderEventDroppedError { error_code = "out_of_order", error_type = error_type::CONDITION_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, ); emit!(ComponentEventsDropped:: { @@ -68,7 +66,6 @@ impl InternalEvent for LokiOutOfOrderEventRewritten { message = "Timestamps rewritten.", count = self.count, reason = "out_of_order", - internal_log_rate_limit = true, ); counter!("rewritten_timestamp_events_total").increment(self.count as u64); } @@ -86,7 +83,6 @@ impl InternalEvent for LokiTimestampNonParsableEventsDropped { error_code = "non-parsable_timestamp", error_type = error_type::CONDITION_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, ); emit!(ComponentEventsDropped:: { count: 1, reason }); diff --git a/src/internal_events/lua.rs b/src/internal_events/lua.rs index 2805b5b57917d..392f1b8b26199 100644 --- a/src/internal_events/lua.rs +++ b/src/internal_events/lua.rs @@ -28,7 +28,6 @@ impl InternalEvent for LuaScriptError { error_code = mlua_error_code(&self.error), error_type = error_type::COMMAND_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", @@ -58,7 +57,7 @@ impl InternalEvent for LuaBuildError { error_type = error_type::SCRIPT_FAILED, error_code = lua_build_error_code(&self.error), stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/metric_to_log.rs b/src/internal_events/metric_to_log.rs index 79a9d117054a8..5bbceeb5017c6 100644 --- a/src/internal_events/metric_to_log.rs +++ b/src/internal_events/metric_to_log.rs @@ -16,7 +16,6 @@ impl InternalEvent for MetricToLogSerializeError { error = ?self.error, error_type = error_type::ENCODER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true ); counter!( "component_errors_total", diff --git a/src/internal_events/mongodb_metrics.rs b/src/internal_events/mongodb_metrics.rs index 8d292342d3f0d..cf57b7af94e6a 100644 --- a/src/internal_events/mongodb_metrics.rs +++ b/src/internal_events/mongodb_metrics.rs @@ -48,7 +48,7 @@ impl InternalEvent for MongoDbMetricsRequestError<'_> { error = ?self.error, error_type = error_type::REQUEST_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -72,7 +72,7 @@ impl InternalEvent for MongoDbMetricsBsonParseError<'_> { error = ?self.error, error_type = error_type::PARSER_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/mqtt.rs b/src/internal_events/mqtt.rs index d20ccad0bad98..507f4aea2464c 100644 --- a/src/internal_events/mqtt.rs +++ b/src/internal_events/mqtt.rs @@ -18,7 +18,7 @@ impl InternalEvent for MqttConnectionError { error_code = "mqtt_connection_error", error_type = error_type::WRITER_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/nginx_metrics.rs b/src/internal_events/nginx_metrics.rs index 02f3309aec3a1..d6561ccf21096 100644 --- a/src/internal_events/nginx_metrics.rs +++ b/src/internal_events/nginx_metrics.rs @@ -48,7 +48,7 @@ impl InternalEvent for NginxMetricsRequestError<'_> { error = %self.error, error_type = error_type::REQUEST_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -73,7 +73,7 @@ impl InternalEvent for NginxMetricsStubStatusParseError<'_> { error = %self.error, error_type = error_type::PARSER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/parser.rs b/src/internal_events/parser.rs index 84cd0556b4821..3638ab4189e7b 100644 --- a/src/internal_events/parser.rs +++ b/src/internal_events/parser.rs @@ -30,7 +30,6 @@ impl InternalEvent for ParserMatchError<'_> { error_type = error_type::CONDITION_FAILED, stage = error_stage::PROCESSING, field = &truncate_string_at(&String::from_utf8_lossy(self.value), 60)[..], - internal_log_rate_limit = true ); counter!( "component_errors_total", diff --git a/src/internal_events/postgresql_metrics.rs b/src/internal_events/postgresql_metrics.rs index 8843140cb54e7..d7979f8dd1185 100644 --- a/src/internal_events/postgresql_metrics.rs +++ b/src/internal_events/postgresql_metrics.rs @@ -16,7 +16,7 @@ impl InternalEvent for PostgresqlMetricsCollectError<'_> { error_type = error_type::REQUEST_FAILED, stage = error_stage::RECEIVING, endpoint = %self.endpoint, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/process.rs b/src/internal_events/process.rs index 5a54154eca849..ef30c1ea9e7e2 100644 --- a/src/internal_events/process.rs +++ b/src/internal_events/process.rs @@ -73,7 +73,6 @@ impl InternalEvent for VectorReloadError { error_code = "reload", error_type = error_type::CONFIGURATION_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", @@ -95,7 +94,6 @@ impl InternalEvent for VectorConfigLoadError { error_code = "config_load", error_type = error_type::CONFIGURATION_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", @@ -117,7 +115,6 @@ impl InternalEvent for VectorRecoveryError { error_code = "recovery", error_type = error_type::CONFIGURATION_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", diff --git a/src/internal_events/prometheus.rs b/src/internal_events/prometheus.rs index 752e8e238fac4..2285ee1323773 100644 --- a/src/internal_events/prometheus.rs +++ b/src/internal_events/prometheus.rs @@ -24,7 +24,7 @@ impl InternalEvent for PrometheusParseError<'_> { error = ?self.error, error_type = error_type::PARSER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); debug!( message = %format!("Failed to parse response:\n\n{}\n\n", self.body), @@ -53,7 +53,7 @@ impl InternalEvent for PrometheusRemoteWriteParseError { error = ?self.error, error_type = error_type::PARSER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -74,7 +74,6 @@ impl InternalEvent for PrometheusNormalizationError { message = normalization_reason, error_type = error_type::CONVERSION_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", diff --git a/src/internal_events/pulsar.rs b/src/internal_events/pulsar.rs index c03dea3870086..416768fcff6a5 100644 --- a/src/internal_events/pulsar.rs +++ b/src/internal_events/pulsar.rs @@ -19,7 +19,7 @@ impl InternalEvent for PulsarSendingError { error = %self.error, error_type = error_type::REQUEST_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -46,7 +46,7 @@ impl InternalEvent for PulsarPropertyExtractionError { error_type = error_type::PARSER_FAILED, stage = error_stage::PROCESSING, property_field = %self.property_field, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -105,7 +105,7 @@ registered_event!( error_code = "reading_message", error_type = error_type::READER_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); self.read_errors.increment(1_u64); @@ -117,7 +117,7 @@ registered_event!( error_code = "acknowledge_message", error_type = error_type::ACKNOWLEDGMENT_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); self.ack_errors.increment(1_u64); @@ -129,7 +129,7 @@ registered_event!( error_code = "negative_acknowledge_message", error_type = error_type::ACKNOWLEDGMENT_FAILED, stage = error_stage::RECEIVING, - internal_log_rate_limit = true, + ); self.nack_errors.increment(1_u64); diff --git a/src/internal_events/redis.rs b/src/internal_events/redis.rs index 0ac9e9e59d417..32af514f4215d 100644 --- a/src/internal_events/redis.rs +++ b/src/internal_events/redis.rs @@ -23,7 +23,7 @@ impl InternalEvent for RedisReceiveEventError { error_code = %self.error_code, error_type = error_type::READER_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/reduce.rs b/src/internal_events/reduce.rs index b9887aaf54bb7..c62c1ed3639fa 100644 --- a/src/internal_events/reduce.rs +++ b/src/internal_events/reduce.rs @@ -26,7 +26,7 @@ impl InternalEvent for ReduceAddEventError { error = ?self.error, error_type = error_type::CONDITION_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/remap.rs b/src/internal_events/remap.rs index d05e6dfb9c874..93193941b23fe 100644 --- a/src/internal_events/remap.rs +++ b/src/internal_events/remap.rs @@ -19,7 +19,7 @@ impl InternalEvent for RemapMappingError { error = ?self.error, error_type = error_type::CONVERSION_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/sematext_metrics.rs b/src/internal_events/sematext_metrics.rs index b4b5be737fb2e..67839e8c90e79 100644 --- a/src/internal_events/sematext_metrics.rs +++ b/src/internal_events/sematext_metrics.rs @@ -19,7 +19,7 @@ impl InternalEvent for SematextMetricsInvalidMetricError<'_> { stage = error_stage::PROCESSING, value = ?self.metric.value(), kind = ?self.metric.kind(), - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -46,7 +46,7 @@ impl InternalEvent for SematextMetricsEncodeEventError error = %self.error, error_type = error_type::ENCODER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/socket.rs b/src/internal_events/socket.rs index 97a648da2587b..fa68e5fc1854d 100644 --- a/src/internal_events/socket.rs +++ b/src/internal_events/socket.rs @@ -122,7 +122,7 @@ impl InternalEvent for SocketBindError { error_type = error_type::IO_FAILED, stage = error_stage::RECEIVING, %mode, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -151,7 +151,7 @@ impl InternalEvent for SocketReceiveError { error_type = error_type::READER_FAILED, stage = error_stage::RECEIVING, %mode, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -181,7 +181,7 @@ impl InternalEvent for SocketSendError { error_type = error_type::WRITER_FAILED, stage = error_stage::SENDING, %mode, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/splunk_hec.rs b/src/internal_events/splunk_hec.rs index 4ff5838cdc0b7..e4853c1a8b40e 100644 --- a/src/internal_events/splunk_hec.rs +++ b/src/internal_events/splunk_hec.rs @@ -33,7 +33,7 @@ mod sink { error_code = "serializing_json", error_type = error_type::ENCODER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -62,7 +62,7 @@ mod sink { stage = error_stage::PROCESSING, value = ?self.value, kind = ?self.kind, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -92,7 +92,7 @@ mod sink { error_code = "invalid_response", error_type = error_type::PARSER_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -118,7 +118,7 @@ mod sink { error_code = "indexer_ack_failed", error_type = error_type::ACKNOWLEDGMENT_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -143,7 +143,7 @@ mod sink { error_code = "indexer_ack_unavailable", error_type = error_type::ACKNOWLEDGMENT_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/statsd_sink.rs b/src/internal_events/statsd_sink.rs index 165ef885eabbd..b7ee84cfbc457 100644 --- a/src/internal_events/statsd_sink.rs +++ b/src/internal_events/statsd_sink.rs @@ -20,7 +20,7 @@ impl InternalEvent for StatsdInvalidMetricError<'_> { stage = error_stage::PROCESSING, value = ?self.value, kind = ?self.kind, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/tag_cardinality_limit.rs b/src/internal_events/tag_cardinality_limit.rs index 4c0c315eb11c1..e0a79e583bbcc 100644 --- a/src/internal_events/tag_cardinality_limit.rs +++ b/src/internal_events/tag_cardinality_limit.rs @@ -14,7 +14,6 @@ impl InternalEvent for TagCardinalityLimitRejectingEvent<'_> { metric_name = self.metric_name, tag_key = self.tag_key, tag_value = self.tag_value, - internal_log_rate_limit = true, ); counter!("tag_value_limit_exceeded_total").increment(1); @@ -38,7 +37,6 @@ impl InternalEvent for TagCardinalityLimitRejectingTag<'_> { metric_name = self.metric_name, tag_key = self.tag_key, tag_value = self.tag_value, - internal_log_rate_limit = true, ); counter!("tag_value_limit_exceeded_total").increment(1); } diff --git a/src/internal_events/tcp.rs b/src/internal_events/tcp.rs index 23ec1fc88e830..ae050b99be309 100644 --- a/src/internal_events/tcp.rs +++ b/src/internal_events/tcp.rs @@ -60,7 +60,6 @@ impl InternalEvent for TcpSocketError<'_, E> { peer_addr = ?self.peer_addr, error_type = error_type::CONNECTION_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", @@ -89,7 +88,6 @@ impl InternalEvent for TcpSocketTlsConnectionError { debug!( message = "Connection error, probably a healthcheck.", error = %self.error, - internal_log_rate_limit = true, ); } _ => { @@ -99,7 +97,6 @@ impl InternalEvent for TcpSocketTlsConnectionError { error_code = "connection_failed", error_type = error_type::WRITER_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", @@ -127,7 +124,6 @@ impl InternalEvent for TcpSendAckError { error_code = "ack_failed", error_type = error_type::WRITER_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", diff --git a/src/internal_events/template.rs b/src/internal_events/template.rs index 82df77cefdb8d..c7b42b1b10363 100644 --- a/src/internal_events/template.rs +++ b/src/internal_events/template.rs @@ -23,7 +23,7 @@ impl InternalEvent for TemplateRenderingError<'_> { error = %self.error, error_type = error_type::TEMPLATE_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( @@ -43,7 +43,7 @@ impl InternalEvent for TemplateRenderingError<'_> { error = %self.error, error_type = error_type::TEMPLATE_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); } } diff --git a/src/internal_events/udp.rs b/src/internal_events/udp.rs index 15e9df4c2b07b..b983543e6cae1 100644 --- a/src/internal_events/udp.rs +++ b/src/internal_events/udp.rs @@ -47,7 +47,6 @@ impl InternalEvent for UdpSendIncompleteError { dropped = self.data_size - self.sent, error_type = error_type::WRITER_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", diff --git a/src/internal_events/unix.rs b/src/internal_events/unix.rs index a45777ab8f2e1..f66327011da98 100644 --- a/src/internal_events/unix.rs +++ b/src/internal_events/unix.rs @@ -54,7 +54,7 @@ impl InternalEvent for UnixSocketError<'_, E> { path = ?self.path, error_type = error_type::CONNECTION_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -80,7 +80,7 @@ impl InternalEvent for UnixSocketSendError<'_, E> { path = ?self.path, error_type = error_type::WRITER_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -109,7 +109,6 @@ impl InternalEvent for UnixSendIncompleteError { dropped = self.data_size - self.sent, error_type = error_type::WRITER_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", @@ -137,7 +136,7 @@ impl InternalEvent for UnixSocketFileDeleteError<'_> { error_code = "delete_socket_file", error_type = error_type::WRITER_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/websocket.rs b/src/internal_events/websocket.rs index 59d64574940f4..bd3bbb78a6ede 100644 --- a/src/internal_events/websocket.rs +++ b/src/internal_events/websocket.rs @@ -33,7 +33,7 @@ impl InternalEvent for WsConnectionFailedError { error_code = "ws_connection_error", error_type = error_type::CONNECTION_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", @@ -76,7 +76,7 @@ impl InternalEvent for WsConnectionError { error_code = "ws_connection_error", error_type = error_type::WRITER_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/websocket_server.rs b/src/internal_events/websocket_server.rs index 2fdb79394998e..881cba02a0b9d 100644 --- a/src/internal_events/websocket_server.rs +++ b/src/internal_events/websocket_server.rs @@ -43,7 +43,7 @@ impl InternalEvent for WsListenerConnectionFailedError { error_code = "ws_connection_error", error_type = error_type::CONNECTION_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, + ); let mut all_tags = self.extra_tags.clone(); all_tags.extend([ @@ -100,7 +100,7 @@ impl InternalEvent for WsListenerSendError { error_code = "ws_server_connection_error", error_type = error_type::WRITER_FAILED, stage = error_stage::SENDING, - internal_log_rate_limit = true, + ); counter!( "component_errors_total", diff --git a/src/internal_events/windows.rs b/src/internal_events/windows.rs index 994b89345e3c0..f44c0a26bc8f3 100644 --- a/src/internal_events/windows.rs +++ b/src/internal_events/windows.rs @@ -102,7 +102,6 @@ impl InternalEvent for WindowsServiceDoesNotExistError<'_> { error_code = "service_missing", error_type = error_type::CONDITION_FAILED, stage = error_stage::PROCESSING, - internal_log_rate_limit = true, ); counter!( "component_errors_total", diff --git a/src/sinks/datadog/logs/sink.rs b/src/sinks/datadog/logs/sink.rs index 6e2ca1df8f3c3..4d7f3fe1f77fa 100644 --- a/src/sinks/datadog/logs/sink.rs +++ b/src/sinks/datadog/logs/sink.rs @@ -159,7 +159,6 @@ pub fn position_reserved_attr_event_root( message = "Semantic meaning is defined, but the event path already exists. Renaming to not overwrite.", meaning = meaning, renamed = &rename_attr, - internal_log_rate_limit = true, ); log.rename_key(desired_path, rename_path); } diff --git a/src/sinks/datadog/traces/apm_stats/flusher.rs b/src/sinks/datadog/traces/apm_stats/flusher.rs index d1ee1e73e949b..e529f49869dbd 100644 --- a/src/sinks/datadog/traces/apm_stats/flusher.rs +++ b/src/sinks/datadog/traces/apm_stats/flusher.rs @@ -70,7 +70,6 @@ pub async fn flush_apm_stats_thread( } Err(_) => { error!( - internal_log_rate_limit = true, message = "Tokio Sender unexpectedly dropped." ); break; diff --git a/src/sinks/gcp/stackdriver/logs/encoder.rs b/src/sinks/gcp/stackdriver/logs/encoder.rs index 5b4faaac8740e..f8dbdee3bec4d 100644 --- a/src/sinks/gcp/stackdriver/logs/encoder.rs +++ b/src/sinks/gcp/stackdriver/logs/encoder.rs @@ -173,7 +173,6 @@ pub(super) fn remap_severity(severity: Value) -> Value { warn!( message = "Unknown severity value string, using DEFAULT.", value = %s, - internal_log_rate_limit = true ); 0 } diff --git a/src/sinks/util/adaptive_concurrency/controller.rs b/src/sinks/util/adaptive_concurrency/controller.rs index 4457e71cad4a7..227ee29c7122a 100644 --- a/src/sinks/util/adaptive_concurrency/controller.rs +++ b/src/sinks/util/adaptive_concurrency/controller.rs @@ -291,7 +291,6 @@ where warn!( message = "Unhandled error response.", %error, - internal_log_rate_limit = true ); false } diff --git a/src/sinks/util/retries.rs b/src/sinks/util/retries.rs index e265be25a9089..ff3932a9d1b90 100644 --- a/src/sinks/util/retries.rs +++ b/src/sinks/util/retries.rs @@ -152,7 +152,6 @@ where error!( message = "OK/retry response but retries exhausted; dropping the request.", reason = ?reason, - internal_log_rate_limit = true, ); return None; } @@ -182,7 +181,7 @@ where error!( message = "Non-retriable error; dropping the request.", %error, - internal_log_rate_limit = true, + ); None } @@ -196,7 +195,6 @@ where error!( message = "Unexpected error type; dropping the request.", %error, - internal_log_rate_limit = true ); None } diff --git a/src/sources/datadog_agent/metrics.rs b/src/sources/datadog_agent/metrics.rs index a27400e995ef1..b093df4a31a5a 100644 --- a/src/sources/datadog_agent/metrics.rs +++ b/src/sources/datadog_agent/metrics.rs @@ -182,10 +182,7 @@ fn decode_datadog_sketches( ) -> Result, ErrorMessage> { if body.is_empty() { // The datadog agent may send an empty payload as a keep alive - debug!( - message = "Empty payload ignored.", - internal_log_rate_limit = true - ); + debug!(message = "Empty payload ignored.",); return Ok(Vec::new()); } diff --git a/src/sources/heroku_logs.rs b/src/sources/heroku_logs.rs index c4bde0c2898e1..c86dec895eb7a 100644 --- a/src/sources/heroku_logs.rs +++ b/src/sources/heroku_logs.rs @@ -407,7 +407,6 @@ fn line_to_events( warn!( message = "Line didn't match expected logplex format, so raw message is forwarded.", fields = parts.len(), - internal_log_rate_limit = true ); events.push(LogEvent::from_str_legacy(line).into()) diff --git a/src/sources/socket/udp.rs b/src/sources/socket/udp.rs index a1b39c2fbcd33..dcf15a76cfb3a 100644 --- a/src/sources/socket/udp.rs +++ b/src/sources/socket/udp.rs @@ -183,7 +183,6 @@ pub(super) fn udp( warn!( message = "Discarding frame larger than max_length.", max_length = max_length, - internal_log_rate_limit = true ); continue; } @@ -211,7 +210,6 @@ pub(super) fn udp( warn!( message = "Discarding frame larger than max_length.", max_length = max_length, - internal_log_rate_limit = true ); } diff --git a/src/transforms/lua/v1/mod.rs b/src/transforms/lua/v1/mod.rs index 1255365f22116..97cef1684ea8e 100644 --- a/src/transforms/lua/v1/mod.rs +++ b/src/transforms/lua/v1/mod.rs @@ -255,7 +255,6 @@ impl mlua::UserData for LuaEvent { message = "Could not set field to Lua value of invalid type, dropping field.", field = key.as_str(), - internal_log_rate_limit = true ); this.inner.as_mut_log().remove(&key_path); }