Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how to also support axios or other http providers #1091

Open
victhorbi opened this issue Jul 29, 2024 · 1 comment
Open

Investigate how to also support axios or other http providers #1091

victhorbi opened this issue Jul 29, 2024 · 1 comment

Comments

@victhorbi
Copy link
Collaborator

Context

Axios was originally chosen by the team to handle http requests.
However, it was coming with an additional dependency, and it was causing conflicts for projects willing to migrate to using the sdk that were coming from thor-devkit.
The Team eventually agreed to move to Fetch, that is native in javascript.

Description

Since Axios comes with many pros, like automatic polyfills, easy syntax and suitability for advanced use-cases, we are keen to support it either, as a pluggable part of the sdk.
Best would be to support a generic http provider, it's acceptable to only support axios as the alternative.

Acceptance criteria

  • the custom provider must be specified with an optional argument
  • the use of the standard (fetch) vs the custom http provider must be transparent for the sdk
  • shall not figure as dependency
@victhorbi victhorbi added this to the Audit milestone Aug 1, 2024
@victhorbi
Copy link
Collaborator Author

Let's wait for the official release (not supporting axios) to be out before starting this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants