Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generated code readability issues #1221

Open
Lucasharskamp opened this issue Sep 27, 2023 · 0 comments
Open

Auto-generated code readability issues #1221

Lucasharskamp opened this issue Sep 27, 2023 · 0 comments

Comments

@Lucasharskamp
Copy link
Collaborator

Lucasharskamp commented Sep 27, 2023

Of course this is code the user isn't meant to edit (since it will re-generate anyways) but readability is deemed necessary so the user has an idea of what is going on; otherwise, the file might've as well been minimized and void of comments.

Problem 1) Unnecessary use of local variables of properties
image
If a private variable that exposes a property never gets used except for the property itself, one might as well just use an auto-property. This should not hurt the functionality of the variable editor within the FRB editor.

Problem 2) Lack of indentation when creating relationships between (stacks of) object(s)
image

Problem 3) Let GetStaticMember redirect to GetFile
image
(If they are returning the same object state based on parameter input, of course, I am not certain if that is the case)

Problem 4) Lack of localization for comments
image
Since these files are all generated for each user, and therefore not part of a shared whole, they might as well just be having localized comments for sake of ease of use. This should be especially useful for summaries above methods, e.g. those in auto-generated factories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants