Mark all functions that use wait
as noasync
#3168
Merged
+353
−182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.98.0
Application.make()
NIO's
EventLoopFuture.wait()
is marked asnoasync
because is can cause issues when used in a concurrency context. All places where we call.wait()
should also be marked asnoasync
to avoid this issue.This adds
async
alternatives for those functions and addsnoasync
annotations where appropriate.Also adds an
async
Application.make
to replace the old initialiser that is nownoasync