You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Because these budgets involve several closure assumptions, the physical meaning of each of these tendency terms is not always obvious. We should comment the code to make it clear which physical processes are encompassed in different tendency terms. This will be based on @qingli411's commented code.
For future reference: changing the tendency terms, and adding them as save-able output variables requires the following steps:
@vanroekel Yes, and I had not noticed their registry appearance so thanks for that! I'll try and do this in the next few days. I do have a question:
@katsmith133 & I discussed re-arranging/naming the tendency terms based on their physics (i.e. w2tend_entrain, w2tend_transport, w2tend_buoyancy, w2tend_pressure_isotropy/w2tend_pressure_slow, w2tend_pressure_shear/w2tend_pressure_rapid, w2tend_splat). Would you support this approach? This would reduce the amount of commenting required and also make it easier to directly compare budgets between the LES and ADC scheme (e.g. Issue #13)
The current tendency terms are decomposed into various terms that arise from a range of physical processes, e.g.
MPAS-Model/src/core_ocean/shared/mpas_ocn_adcReconstruct.F
Lines 565 to 569 in 5dc8d6e
Because these budgets involve several closure assumptions, the physical meaning of each of these tendency terms is not always obvious. We should comment the code to make it clear which physical processes are encompassed in different tendency terms. This will be based on @qingli411's commented code.
For future reference: changing the tendency terms, and adding them as save-able output variables requires the following steps:
MPAS-Model/src/core_ocean/shared/mpas_ocn_adcReconstruct.F
Line 566 in 103e68e
MPAS-Model/src/core_ocean/adc_mixing/Registry_adc_mixing_fields_opts.xml
Lines 269 to 270 in 103e68e
MPAS-Model/src/core_ocean/adc_mixing/Registry_adc_mixing_fields_opts.xml
Line 576 in 103e68e
mpas_ocn_turbulence.F
in various places.mpas_ocn_vmix_adc.F
for deallocation:MPAS-Model/src/core_ocean/shared/mpas_ocn_vmix_adc.F
Line 531 in 103e68e
streams.ocean
file of theforward
run directoryThe text was updated successfully, but these errors were encountered: