Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array type for properties values #312

Closed
damienflament opened this issue Apr 28, 2024 · 2 comments
Closed

Array type for properties values #312

damienflament opened this issue Apr 28, 2024 · 2 comments

Comments

@damienflament
Copy link

Hi !

I'm currently working with your excellent library and Bulma CSS.

As Bulma is based on CSS classes, it can require many values in the class property.

A simple example here, with a tag color depending on a flag:

div({ class: 'tags' },
  span({ class: config.persistence ? 'tag is-success' : 'tag is-warning' }, 'Persistence'),
  span({ class: config.serviceWorker ? 'tag is-success' : 'tag is-warning' }, 'Service Worker')
)

To prevent repeating the constant values, we can use an array and the join function:

div({ class: 'tags' },
  span({ class: ['tag', config.persistence ? 'is-success' : 'is-warning'].join(' ') }, 'Persistence'),
  span({ class: ['tag', config.serviceWorker ? 'is-success' : 'is-warning'].join(' ') }, 'Service Worker')
)

But I like VanJS because it allows to write components in pure JS in a declarative way. A bit more of syntactic sugar can't hurt !

Allowing Array values by joining can do the job:

div({ class: 'tags' },
  span({ class: ['tag', config.persistence ? 'is-success' : 'is-warning'] }, 'Persistence'),
  span({ class: ['tag', config.serviceWorker ? 'is-success' : 'is-warning'] }, 'Service Worker')
)

What about that ?

@Tao-VanJS
Copy link
Member

My take is that adding join(" ") at the end isn't too much overhead. It probably doesn't worth the complexity of introducing the special handling of class property.

@damienflament
Copy link
Author

Just come back after thinking about template strings.

div({ class: 'tags' },
  span({ class: `tag  ${config.persistence ? 'is-success' : 'is-warning'}` }, 'Persistence'),
  span({ class: `tag  ${config.serviceWorker ? 'is-success' : 'is-warning'}` }, 'Service Worker')
)

This library is definitely perfect as it is.

Thanks for your work !

I close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants