Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typescript support for vanjs-cone (auto-inferred by ChatGP… #190

Closed
wants to merge 1 commit into from
Closed

Conversation

yahia-berashish
Copy link
Contributor

This PR closes #189

@Tao-VanJS
Copy link
Member

@b-rad-c, let me know if this PR looks good to you.

@b-rad-c
Copy link
Contributor

b-rad-c commented Dec 14, 2023

Hey @Tao-VanJS - you can cancel this pull request, I was speaking with the author on a few different threads (here and here) and they're going to update the code and send a pull request to my fork of the van repository and then once I approve I'll send a pull request upstream to your repo.

In the last Van Cone update that you just merged I updated the readme with contribution instructions. Submissions should go to my repo first and then I'll confirm and potentially modify and then send you an upstream pull request.

Thanks!

@Tao-VanJS
Copy link
Member

Thanks @b-rad-c for letting me know! Cancelling this PR.

@Tao-VanJS Tao-VanJS closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding TypeScript support VanCone
3 participants