Set up imgui from Conan properly

Author: valgur

.gitignore

@@ -4,6 +4,7 @@ install*
 cupoch_config.h
 shader.h
 imgui.ini
+/src/cupoch/visualization/visualizer/imgui/
 site/*
 __pycache__
 .idea/

CMakeLists.txt

@@ -137,17 +137,12 @@ target_compile_options(cupoch_flags INTERFACE
     "$<$<COMPILE_LANGUAGE:CUDA>:--expt-extended-lambda>"
     "$<$<COMPILE_LANGUAGE:CUDA>:--default-stream=per-thread>"
     "$<$<COMPILE_LANGUAGE:CUDA>:--use_fast_math>"
+    "$<$<BOOL:UNIX>:$<$<COMPILE_LANGUAGE:CUDA>:--compiler-options=-fPIC>>"
     "$<$<COMPILE_LANGUAGE:CUDA>:-Xcudafe=--diag_suppress=integer_sign_change>"
     "$<$<COMPILE_LANGUAGE:CUDA>:-Xcudafe=--diag_suppress=partial_override>"
     "$<$<COMPILE_LANGUAGE:CUDA>:-Xcudafe=--diag_suppress=virtual_function_decl_hidden>"
 )
-target_link_libraries(cupoch_flags INTERFACE
-    CUDA::cudart
-#    CUDA::cublas
-#    CUDA::cudnn
-#    CUDA::cufft
-#    CUDA::curand
-)
+target_link_libraries(cupoch_flags INTERFACE CUDA::cudart)
 if (USE_RMM)
     target_compile_definitions(cupoch_flags INTERFACE USE_RMM)
 endif ()

conanfile.py

@@ -2,6 +2,7 @@
 
 from conan import ConanFile
 from conan.tools.cmake import CMake, CMakeDeps, CMakeToolchain, cmake_layout
+from conan.tools.files import copy
 
 # for self.info.clear()
 required_conan_version = ">=1.50.0"
@@ -54,13 +55,24 @@ def layout(self):
         cmake_layout(self)
 
     def generate(self):
+        imgui_paths = self.dependencies["imgui/1.89.1"].cpp_info.srcdirs
+        backends_dir = next(path for path in imgui_paths if path.endswith("bindings"))
+        output_dir = os.path.join(self.source_folder, "src/cupoch/visualization/visualizer/imgui/backends")
+        for backend_file in [
+            "imgui_impl_glfw.h",
+            "imgui_impl_glfw.cpp",
+            "imgui_impl_opengl3.h",
+            "imgui_impl_opengl3_loader.h",
+            "imgui_impl_opengl3.cpp",
+        ]:
+            copy(self, backend_file, backends_dir, output_dir)
+
         tc = CMakeToolchain(self)
         # Do not set CXX, C flags from Conan to avoid adding -stdlib=libstdc++
         tc.blocks.remove("cmake_flags_init")
         tc.cache_variables["BUILD_TESTING"] = self._with_unit_tests
-        # tc.preprocessor_definitions["FLANN_USE_CUDA"] = 1
-        # tc.preprocessor_definitions["SPDLOG_FMT_EXTERNAL"] = 1
         tc.generate()
+
         CMakeDeps(self).generate()
 
     def build(self):

src/cupoch/visualization/CMakeLists.txt

@@ -34,7 +34,7 @@ target_link_libraries(cupoch_visualization
         cupoch_utility
         Eigen3::Eigen
         GLEW::GLEW
-        glfw3
+        glfw
     PRIVATE
         cupoch_io
         imgui::imgui

src/cupoch/visualization/shader/geometry_renderer.cpp

@@ -114,8 +114,10 @@ bool GraphRenderer<Dim>::UpdateGeometry() {
     return true;
 }
 
+namespace cupoch::visualization::glsl {
 template class GraphRenderer<2>;
 template class GraphRenderer<3>;
+}  // namespace cupoch::visualization::glsl
 
 bool TriangleMeshRenderer::Render(const RenderOption &option,
                                   const ViewControl &view) {

src/cupoch/visualization/visualizer/visualizer.cpp

@@ -21,8 +21,8 @@
 #include "cupoch/visualization/visualizer/visualizer.h"
 
 #include <imgui.h>
-#include <imgui/backends/imgui_impl_glfw.h>
-#include <imgui/backends/imgui_impl_opengl3.h>
+#include "imgui/backends/imgui_impl_glfw.h"
+#include "imgui/backends/imgui_impl_opengl3.h"
 
 #include "cupoch/geometry/lineset.h"
 #include "cupoch/geometry/trianglemesh.h"

src/cupoch/visualization/visualizer/visualizer_renderer.cpp

@@ -19,8 +19,8 @@
  * IN THE SOFTWARE.
 **/
 #include <imgui.h>
-#include <imgui/backends/imgui_impl_glfw.h>
-#include <imgui/backends/imgui_impl_opengl3.h>
+#include "imgui/backends/imgui_impl_glfw.h"
+#include "imgui/backends/imgui_impl_opengl3.h"
 
 #include "cupoch/geometry/trianglemesh.h"
 #include "cupoch/io/class_io/ijson_convertible_io.h"

third_party/CMakeLists.txt

@@ -14,7 +14,7 @@ add_library(flann_cuda_s STATIC ${CU_SOURCES})
 add_library(flann::flann_cuda_s ALIAS flann_cuda_s)
 target_include_directories(flann_cuda_s PUBLIC "${CMAKE_CURRENT_SOURCE_DIR}")
 target_compile_definitions(flann_cuda_s PUBLIC FLANN_USE_CUDA)
-target_link_libraries(flann_cuda_s PRIVATE spdlog::spdlog rmm::rmm)
+target_link_libraries(flann_cuda_s PRIVATE cupoch_flags CUDA::cudart spdlog::spdlog rmm::rmm)
 list(APPEND 3RDPARTY_LIBRARIES flann_cuda_s)
 
 # liblzf
@@ -43,8 +43,8 @@ add_subdirectory(stdgpu)
 set_target_properties(stdgpu PROPERTIES POSITION_INDEPENDENT_CODE ON)
 target_include_directories(stdgpu INTERFACE
     $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/stdgpu/src>
-    $<INSTALL_INTERFACE:stdgpu/src>
     $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/stdgpu/src/stdgpu/include>
+    $<INSTALL_INTERFACE:stdgpu/src>
     $<INSTALL_INTERFACE:stdgpu/src/stdgpu/include>)
 list(APPEND 3RDPARTY_LIBRARIES stdgpu)
 
@@ -124,7 +124,7 @@ target_include_directories(sgm PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/libSGM/include
 target_include_directories(sgm PUBLIC
     $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/libSGM/include>
     $<INSTALL_INTERFACE:libSGM/include>)
-target_link_libraries(sgm PUBLIC CUDA::cudart)
+target_link_libraries(sgm PUBLIC cupoch_flags CUDA::cudart)
 list(APPEND 3RDPARTY_LIBRARIES sgm)