Skip to content

Update minecraft 1.21 #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 55 commits into
base: main
Choose a base branch
from
Draft

Update minecraft 1.21 #675

wants to merge 55 commits into from

Conversation

JackCrumpLeys
Copy link
Contributor

@JackCrumpLeys JackCrumpLeys commented Nov 13, 2024 •
edited
Loading

Update to minecraft 1.21.*

What needs to be done:

  • Get all the extracted data integrated and generating code correctly.
  • Getting all the packets renamed, edited and updated. (HUGE thanks to @lukashermansson ❤️) (1.21.3)
    • do this for 1.21.x
  • Getting it to compile with no errors.
    • do this for 1.21.x
  • Get everything new in 1.21.x though to the state of the rest of the code
  • Running most basic player join scenario.
  • Confirm validity of all non-networking tests.
  • Rewrite and test all of the networking tests.
  • Research and design comfy abstractions for new ideas in 1.21.x
  • Rewrite and run the ctf example maybe with some new features for 1.21.x
  • Mull over the way networking is done at a base level. (Does 1.21.5 change anything about how the API should operate?)
  • Rewrite all the examples.
  • Start to clean-up and review code.
  • split into smaller easy to review chunks

@JackCrumpLeys JackCrumpLeys marked this pull request as draft November 13, 2024 20:56
JackCrumpLeys and others added 14 commits November 14, 2024 20:02
@JackCrumpLeys
todays work
1f7b46f
@JackCrumpLeys
IT COMPILES.
a227c66
@JackCrumpLeys
Start workiong towards 1.21.3 (extractor working but still need to do…
04ebf47 
… most packet changes.)
@JackCrumpLeys
some work on 1.21.3 new packets and extractor
46799c9
@JackCrumpLeys
todays work
f0f07d6
@alice39
almost working
86ea18c
@alice39
server and client finish the login and configuration phase
c64287f
@JackCrumpLeys
Merge pull request #1 from alice39/update-minecraft-1.21
018cad5 
almost working
@JackCrumpLeys
doing some item stuff
2420d55
@alice39
fix: initial join was sending biomes names instead of dimension names
74b27a6
@alice39
fix: level_chunk_with_light expects a compound with no root name
40b7c7c
@alice39
fix: add missing particle mode field in client_information_c2s play
987bd41
@alice39
fix: client was waiting for game event "start_waiting_for_level_chunks"
4fa65df
@alice39
fix(teleport): implement velocity in updating player position
9b849ea
@JackCrumpLeys
Copy link
Contributor Author

Is anyone else working on this pr?

Just me at the moment. Feel free to help tho.

@maxomatic458
Copy link
Contributor

maxomatic458 commented Dec 19, 2024 •
edited
Loading

@JackCrumpLeys will the 1.21 work be done in this PR or on the next-1.21 branch (on the valence repo)?

Im just gonna assume its here since thats ahead of current master.

@JackCrumpLeys
Copy link
Contributor Author

@JackCrumpLeys will the 1.21 work be done in this PR or on the next-1.21 branch (on the valence repo)?

Im just gonna assume its here since thats ahead of current master.

I plan to split this into smaller prs. Right now I'm just getting all the packets working then I will look into the logic side of things.

@Olle-Lukowski
Copy link

Hey, let me know if you want any help with this! Probably gonna use valence for my project, and would like to use the latest version.

@JackCrumpLeys
Copy link
Contributor Author

JackCrumpLeys commented Jan 7, 2025 •
edited
Loading

@Olle-Lukowski

I would love some help. You can help by simply fixing all the compile errors at the moment. then make sure we have all the packets for 1.21.4 (I think we have all the packets for 1.21.3) then I will make sure the complicated ones all encode/decode correctly.

Right now embarrassingly a file is missing (forgot to git-add) so the packets inspector wont compile (I added a feature to see packets that did not encode/decode) I should have that pushed this late afternoon (~6 hours).

JackCrumpLeys and others added 7 commits January 8, 2025 19:42
@JackCrumpLeys
updates
042d692
@JackCrumpLeys
ignore
674920c
@JackCrumpLeys
fix generator
5f93e5b 
the generator was trying to add 'a to an ident instead of a token stream.
@JackCrumpLeys
fixup nbt exports
122dab9
@JackCrumpLeys
fix
489c2bf
@JackCrumpLeys
work
7f24c82
fix_item
1488c18
dyc3
dyc3 reviewed Apr 3, 2025
View reviewed changes
crates/valence_protocol/src/id_set.rs
pub enum IDSet<'a> {
NamedSet(Cow<'a, str>),
pub enum IDSet {
NamedSet(String),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this to a String from Cow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably wanted to use ID set in a place where 'a is inappropriate e.g item stack. I honestly don't remember and it can probably be made back into a lifetime.

@nicolube
Copy link

nicolube commented Jun 7, 2025 •
edited
Loading

How is this coming along? I've seen that this PR has been quiet for some time.

@maxomatic458
Copy link
Contributor

@nicolube im working on 2 PRs on https://github.com/JackCrumpLeys/valence/ atm

waiting for a review from @JackCrumpLeys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyc3 dyc3 dyc3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@JackCrumpLeys @dyc3 @Sauronzz @maxomatic458 @Olle-Lukowski @nicolube @lukashermansson @alice39 @SelfMadeSystem