Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The composer update crashes on plugin upgrade #68

Open
allanpaiste opened this issue Feb 17, 2021 · 1 comment
Open

The composer update crashes on plugin upgrade #68

allanpaiste opened this issue Feb 17, 2021 · 1 comment
Labels

Comments

@allanpaiste
Copy link
Contributor

This does not happen all the times, but when the amount of changes introduced is large enough and covers things like:

  • renaming methods
  • re-ordering arguments
  • adding new arguments

... then it can cause issues where half of the already in-memory classes are from the old plugin and half from the new (depends on when they were loaded by the autoloader)

Pre-requisites

  1. Use any composer version, on any platform
  2. A use Composer project without the plugin

To Reproduce

  1. Install the plugin on 4.0.0
  2. Upgrade the plugin to latest available version

Expected

The plugin either updates and works right away without issues or some notification is shown on the fact that it can't execute within that run.

Actual

The plugin crashes with a call stack that might lead the user to think that it's broken/unusable - no extra guide presented in the output about the fact that new run would actually work a-ok.

Notes

Maybe the way to deal with this would be to just report that the plugin did not run when it detects that it was updated and a guide would be included how to run it manually.

@allanpaiste allanpaiste changed the title A composer update crashes when plugin upgraded within the call A composer update crashes when plugin upgraded (in some cases) Feb 17, 2021
@allanpaiste allanpaiste changed the title A composer update crashes when plugin upgraded (in some cases) The composer update crashes when plugin upgraded (in some cases) Feb 17, 2021
@allanpaiste allanpaiste changed the title The composer update crashes when plugin upgraded (in some cases) The composer update crashes on plugin upgrade (in some cases) Feb 20, 2021
@allanpaiste allanpaiste changed the title The composer update crashes on plugin upgrade (in some cases) The composer update crashes on plugin upgrade Feb 20, 2021
@ihor-sviziev
Copy link

ihor-sviziev commented Feb 23, 2021

I also had similar issues multiple times with the vaimo composer pathces updates. Usually removing whole vendor and running composer install helps, but that's annoying

@allanpaiste allanpaiste added this to the 3.53.3 milestone Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants