Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defining conflicts in patch entries #52

Open
djacques4gorilla opened this issue Jan 16, 2020 · 0 comments
Open

Defining conflicts in patch entries #52

djacques4gorilla opened this issue Jan 16, 2020 · 0 comments

Comments

@djacques4gorilla
Copy link

Is your feature request related to a problem? Please describe.
Maintaining a central patch list for Magento is challenging due to some conflicts with other packages, for example Magento's ECE Tools. For example, the critical PRODSECBUG-2198 patch is included in ECE Tools starting from a specific version, but would need to be applied on all projects using an older version of ECE tools or that are not on Magento Cloud (i.e. ECE tools is not installed at all). While it is possible to add the patch to the exclusion list at the project level, this has to be done manually for every project that has been updated to a version of ECE tools that includes the patch, even though this condition is known in advance.

Describe the solution you'd like
Just like it's possible to define a conflict node in a Composer file to prevent a package to be installed if another package is installed and fitting the version definition, it would be useful to have a similar node at the patch entry level to skip patches if certain conditions are met.

Describe alternatives you've considered
Alternatively, a special value in the depends node that matches if the module is not present. E.g.

"depends": {
    "magento/ece-tools": "!installed || <=1.12"
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants