New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use WebAssembly build of Yoga #150
Labels
Comments
Thank you! Nice suggestion, I'll see how it works and maybe will integrate it into https://github.com/vadimdemedes/yoga-layout-prebuilt, which Ink uses. |
vadimdemedes
changed the title
Possible startup time optimization
Use WebAssembly build of Yoga
Mar 18, 2019
Another WASM build of Yoga: https://github.com/rickbutton/yoga-wasm |
Nice, I'll check it out. |
Fixed via #550. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi @vadimdemedes! Congrats on shipping v2, it's an amazing project! Thanks for creating it :)
One thing I noticed is that it's startup time takes quite a bit. It takes 150-190ms to run a
require("ink")
in my 2017 MBP.Using
time-require
I found that 70% of that time is spent innode_modules/yoga-layout-prebuilt/yoga-layout/dist/entry-browser.js
, your asm.js build of Yoga. I think this could be improved if Yoga is compiled into wasm.There's no official way doing that in Yoga, but I found this build, which seems to load 2x faster than the asm.js version. It has no docs, and importing it is an async operation, so it may not be a good fit.
The text was updated successfully, but these errors were encountered: