-
Notifications
You must be signed in to change notification settings - Fork 175
Internal errors since upgrading to 24.7.0 #21204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the issue! Could you please provide server logs and possibly the browser console logs once these happens again? |
@mshabarov Thank you for your speedy response!
Here is the exception on the server:
Nothing in the browser logs related to this that I can find. We use Push, yes, with the default mode of Note that today we downgraded to 24.6.5, isolated without any other changes, and no longer see the internal server error banner. Ideally, we'd love to upgrade again :) |
I have the same problems after upgrading. |
Any idea what type of view or usage this happens with? |
@caalador thanks for response. We have a really big app. This happens after uploading sam json files to server. I assume somewhere in afterUpload listener. But I am not completely sure. |
After trying with all the things I could come up with I could not replicate the issue to get any insight on what would be happening. |
@caalador We also have a really big app. I think the bottom line is, something changed between 24.6.5 and 24.7.0 to how Flow handles unexpected message ID errors. Perhaps related to this change? |
The issue is probably related to https://github.com/vaadin/flow/pull/20547/files or https://github.com/vaadin/flow/pull/20749/files. Most likely the former. In 24.6.5, Flow would log and ignore unexpected message IDs, but it looks like it now throws Here is an example flow that could cause an "Unexpected message id" error:
In 24.6.5, when this happened, the server would just ignore the out-of-sequence message and continue. |
This is in my logs. It happens when uploading multiple files:
|
Can you give it a try with Flow 24.7.2? For a Maven project <dependencyManagement>
<dependencies>
<dependency>
<groupId>com.vaadin</groupId>
<artifactId>flow-bom</artifactId>
<version>24.7.2</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-bom</artifactId>
<version>${vaadin.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>
....
<plugin>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-maven-plugin</artifactId>
<version>${vaadin.version}</version>
<configuration>
<forceProductionBuild>true</forceProductionBuild>
</configuration>
....
</plugin>
|
@mcollovati, when I tried to build my prod.bundle with 24.7.2 flow-bom, the build failed:
|
I see. Can you update Vaadin to 24.7.1? That platform version should be compatible with Flow 24.7.2 |
I ended up with error eventually:
The behavior before that seemed different and it is possible it ran longer before giving the error. My case is that I run a really long background job and try to update progress in a dialog. Now, when the job has run for quite some time, the dialog is "reopened"? That is new. But, eventually I get "Unexpected message id from the client" The background job is a bit special: It is a custom test routine that opens up all our screens, and "runs" them (performs default search, selects first row which opens any detail, goes through all tabs, opens all context menus, selects all entries...) This is a bit funky; It is supposed to run in the background, but some elements do end up on screen. |
@mcollovati, looks like my issue was caused by this: #20917 |
@guttormvik2 Thank you for testing the new version and for the feedback. |
Description of the bug
We periodically see "Unexpected message id from the client" errors in the logs. See more about those in this issue: #12640.
On 24.6.5, they didn't cause an internal error. After upgrading to 24.7.0, it seems they now trigger a internal error and make the UI unresponsive.
In our case, we may see these errors more than most because ours users typically have very poor internet. On 24.6.5, it was fine for us because they didn't trigger an internal error.
I should also mention that, since upgrading to 24.7.0, we see these errors more often, but that is a secondary concern to us.
Nothing has changed besides the Vaadin version.
Thank you!
Expected behavior
Upgrading from 24.6.5 to 24.7.0 is a minor release bump. If changes in fact caused the internal errors, it should be fixed, as it breaks existing behavior.
Minimal reproducible example
I am unable to reproduce consistently.
Versions
The text was updated successfully, but these errors were encountered: