Skip to content

Include provided scoped dependencies in Flow maven plugin class scanning #21192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcollovati opened this issue Mar 28, 2025 · 1 comment · Fixed by #21251
Closed

Include provided scoped dependencies in Flow maven plugin class scanning #21192

mcollovati opened this issue Mar 28, 2025 · 1 comment · Fixed by #21251

Comments

@mcollovati
Copy link
Collaborator

Currently, the Flow maven plugin ignores dependencies with provided scope during frontend class scanning, except for portlet and javax.servlet API artifacts.
This filter comes probably from the initial plugin implementation and is most likely not required anymore.

Also, having artifacts in provided scope referencing frontend resources could potentially be a valid use case, for example if the dependency is not packaged with the application but provided at runtime.

@mcollovati
Copy link
Collaborator Author

I did a couple of tests, and it seems including provided dependencies seems not to break builds.

mcollovati added a commit that referenced this issue Apr 9, 2025
Adds the "provided" scope to the list of Maven dependency scopes considered
during class scanning by the Flow maven plugin.

Fixes #21192
@github-project-automation github-project-automation bot moved this from 🅿️Parking lot to Done in Vaadin Flow ongoing work (Vaadin 10+) Apr 11, 2025
@github-project-automation github-project-automation bot moved this from Maybe to Done / Pending Release in Vaadin Flow enhancements backlog (Vaadin 10+) Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants