-
Notifications
You must be signed in to change notification settings - Fork 0
[FEATURE] Toggle Hotswap force page reload from UI #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ref: vaadin/flow#21215 |
Is this feature available for |
The feature is in Flow Hotswapper. For sure, Vaadin HotswapAgent plugin uses Hotswapper when class changes happens. |
Idea: Feature flags panel might be renamed to Settings and we can put more settings there, like those Flow/Vaadin properties. |
JRebel also uses Hotswapper with no modifications, should work as well. |
Is your feature request related to a problem?
Hotswapper page refresh sometimes may produce unwanted effects, like dialogs being closed and not reopened, etc. For this reason, users requested a feature to force Hotswapper to make a full-page reload instead of a refresh when a class changes.
The feature has been implemented in vaadin/flow#21157, and it allows forcing the full reload by setting the
vaadin.hotswap.forcePageReload
system property.However, a server restart is required when the user wants to change the behavior.
Describe the solution you'd like
Given that
Hotswapper
added theforcePageReload
andisForcedPageReload
methods to programmatically activate and deactivate the feature, it would be nice to have a toggle button in Copilot user interface to adjust the behavior at runtime.Describe alternatives you've considered
Implement the feature in the application, like the vaadin/flow#21212 author did.
Additional context
isForcedPageReload
does not consider the system property; it gets true only if the feature has been activated programmatically.The text was updated successfully, but these errors were encountered: