Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly implement packets 8302 and 180b #19

Open
eleriaqueen opened this issue Jul 19, 2023 · 1 comment
Open

Properly implement packets 8302 and 180b #19

eleriaqueen opened this issue Jul 19, 2023 · 1 comment
Labels
cleanup Improving the code quality or refine functionality good first issue Good for newcomers help wanted Extra attention is needed

Comments

@eleriaqueen
Copy link
Contributor

eleriaqueen commented Jul 19, 2023

Currently packets 0x8302 and 0x180b don't have a correct name and are not handled. These two packets should be researched and implemented properly.

Some basic information from different sources:

Packet 0x283

rAthena (wiki):
struct PACKET_ZC_AID { /* this+0x0 */ short PacketType /* this+0x2 */ unsigned long AID }

OpenKore (packetdescriptions.txt):
0283 Account ID

Packet 180b Info:

rAthena:
ZC_EXTEND_BODYITEM_SIZE

Rust-RO (packets_db):

PACKET_ZC_INVENTORY_EXPANSION_INFO {
  short PacketId
  short expansionSize
}
@vE5li vE5li changed the title Information about packets 8302 and 180b Properly implement packets 8302 and 180b Jul 20, 2023
@vE5li vE5li added help wanted Extra attention is needed good first issue Good for newcomers cleanup Improving the code quality or refine functionality labels Jul 20, 2023
@eleriaqueen
Copy link
Contributor Author

eleriaqueen commented Jul 30, 2023

Packet 0x283 is really redundant as it only sends to the client the player character's Game Object ID (it is their Account ID) which Korangar 100% already got from actually logging into the account and getting to character selection.

I'd say give it a name and add comment about it being redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Improving the code quality or refine functionality good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants