Skip to content

[DLX] Support root path when resolving URL #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomerShor merged 2 commits into from
Sep 17, 2025
Merged

[DLX] Support root path when resolving URL #81

TomerShor merged 2 commits into from
Sep 17, 2025

Conversation

@weilerN
Copy link
Collaborator

@weilerN weilerN commented Sep 17, 2025

📝 Description

This PR handles the case where the closest common prefix of a request and the existing ingress is the root path (i.e. \).

🛠️ Changes Made

  • Add a retry Get with the root as a path

✅ Checklist

  • I have tested the changes in this PR

🧪 Testing

  • Dev QA
    • Verified on my setup: a function with ingress / was successfully scaled from zero when invoked with /a/b (screenshot attached).
    • Added unit tests for all scenarios outlined in the HLD, which also validate this fix.

🔗 References

🚨 Breaking Changes?

  • Yes (explain below)
  • No

🔍️ Additional Notes

  • Nuclio should be updated once this CR will be merged and tagged

📸 Screenshots / Logs

image

@weilerN weilerN marked this pull request as ready for review September 17, 2025 12:28
@TomerShor TomerShor merged commit 01b3274 into v3io:development Sep 17, 2025
3 checks passed
@weilerN weilerN mentioned this pull request Sep 17, 2025
Merged
4 tasks
rokatyy pushed a commit to nuclio/nuclio that referenced this pull request Sep 17, 2025
@weilerN
[Dependencies] Bump Scaler version to v0.10.1 (#3809)
3da3d7c 
### 📝 Description
Bump Scaler version to v0.10.1

---

### 🛠️ Changes Made
updated `go.mod`

---

### ✅ Checklist
- [ ] I updated the documentation (if applicable)
- [x] I have tested the changes in this PR

---

### 🧪 Testing
- Did dev QA as part of v3io/scaler#81

---

### 🔗 References
- Ticket link: https://iguazio.atlassian.net/browse/NUC-597
- Design docs links:
- External links:

---

### 🚨 Breaking Changes?

- [ ] Yes (explain below)
- [x] No

<!-- If yes, describe what needs to be changed downstream: -->

---

### 🔍️ Additional Notes
<!-- Anything else reviewers should know (follow-up tasks, known issues,
affected areas etc.). -->
<!-- ### 📸 Screenshots / Logs -->
weilerN added a commit to weilerN/nuclio that referenced this pull request Sep 18, 2025
@weilerN
[Dependencies] Bump Scaler version to v0.10.1 (nuclio#3809)
f939733 
### 📝 Description
Bump Scaler version to v0.10.1

---

### 🛠️ Changes Made
updated `go.mod`

---

### ✅ Checklist
- [ ] I updated the documentation (if applicable)
- [x] I have tested the changes in this PR

---

### 🧪 Testing
- Did dev QA as part of v3io/scaler#81

---

### 🔗 References
- Ticket link: https://iguazio.atlassian.net/browse/NUC-597
- Design docs links:
- External links:

---

### 🚨 Breaking Changes?

- [ ] Yes (explain below)
- [x] No

<!-- If yes, describe what needs to be changed downstream: -->

---

### 🔍️ Additional Notes
<!-- Anything else reviewers should know (follow-up tasks, known issues,
affected areas etc.). -->
<!-- ### 📸 Screenshots / Logs -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rokatyy rokatyy rokatyy approved these changes

@TomerShor TomerShor TomerShor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@weilerN @rokatyy @TomerShor