Commit 01b3274
authored
[DLX] Support root path when resolving URL (#81)
### 📝 Description
This PR handles the case where the closest common prefix of a request
and the existing ingress is the root path (i.e. `\`).
---
### 🛠️ Changes Made
- Add a retry Get with the root as a path
---
### ✅ Checklist
- [x] I have tested the changes in this PR
---
### 🧪 Testing
- Dev QA
- Verified on my setup: a function with ingress / was successfully
scaled from zero when invoked with /a/b (screenshot attached).
- Added unit tests for all scenarios outlined in the HLD, which also
validate this fix.
---
### 🔗 References
- Ticket link: https://iguazio.atlassian.net/browse/NUC-596
- Design docs links:
https://iguazio.atlassian.net/wiki/spaces/PLAT/pages/372080641/DLX+decoupling+ingress-nginx+annotations+HLD#Create-in-memory-cache
- External links:
---
### 🚨 Breaking Changes?
- [ ] Yes (explain below)
- [x] No
<!-- If yes, describe what needs to be changed downstream: -->
---
### 🔍️ Additional Notes
- Nuclio should be updated once this CR will be merged and tagged
### 📸 Screenshots / Logs
<img width="1934" height="948" alt="image"
src="https://github.com/user-attachments/assets/aa794829-8a6a-4e95-a413-dc5a905225a4"
/>1 parent 134e0b6 commit 01b3274
2 files changed
+35
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
104 | 109 | | |
105 | 110 | | |
106 | 111 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
56 | 60 | | |
57 | 61 | | |
58 | 62 | | |
| |||
99 | 103 | | |
100 | 104 | | |
101 | 105 | | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
102 | 131 | | |
103 | 132 | | |
104 | 133 | | |
| |||
0 commit comments