Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Aruba and fix tests #55

Closed
wants to merge 11 commits into from
Closed

Update Aruba and fix tests #55

wants to merge 11 commits into from

Conversation

nodeg
Copy link
Member

@nodeg nodeg commented Aug 28, 2022

This will lock all gems to a specific version, updates aruba to the latest version and fixes the tests

Fixes #37
Fixes #38
Fixes #53

TODO

Bump min. Ruby version due to updated dependencies.

@nodeg nodeg self-assigned this Aug 28, 2022
Fixes #37, #53

Signed-off-by: Dominik Gedon <[email protected]>
Signed-off-by: Dominik Gedon <[email protected]>
Signed-off-by: Dominik Gedon <[email protected]>
Signed-off-by: Dominik Gedon <[email protected]>
Signed-off-by: Dominik Gedon <[email protected]>
Signed-off-by: Dominik Gedon <[email protected]>
Signed-off-by: Dominik Gedon <[email protected]>
Signed-off-by: Dominik Gedon <[email protected]>
The commons-cli package is newer and builds successfully compared to the
commons-collection package.

Signed-off-by: Dominik Gedon <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

No Coverage information No Coverage information
35.2% 35.2% Duplication

@nodeg
Copy link
Member Author

nodeg commented Dec 26, 2022

Closed in favour of another PR.

@nodeg nodeg closed this Dec 26, 2022
@nodeg nodeg deleted the update_gems branch December 26, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjustments for latest aruba version Add specific versions for build and runtime dependencies Fix tests
1 participant