-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example Benchmarks: calculate relative error on repeats #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0da2a7e
to
e0eac8b
Compare
Move class `measurements` from utility.hpp to its own file measurements.hpp to simplify its use at example applications eliminating duplicate declarations on include. Adjust `seismic` example accordingly. Signed-off-by: Dmitrii Golovanov <[email protected]>
Extend class `measurements`: * keep initial number of iterations. * stop() to return duration from the last start(). Add optional prefix and suffix at utility::report_relative_error(). Signed-off-by: Dmitrii Golovanov <[email protected]>
Extend Tachyon example with additional option to execute rendering several times and calculate relative error to estimate rendering performance reliability. Signed-off-by: Dmitrii Golovanov <[email protected]>
Extend the Primes example `n-of-repeats` execution mode to calculate relative error for each of the parallel threads execution block (`n-of-threads`), so it is now possible to measure their performance reliability. Signed-off-by: Dmitrii Golovanov <[email protected]>
241035d
to
09fb18f
Compare
Extend Sudoku example with additional option to repeat solution several times and calculate relative error to estimate performance reliability. Signed-off-by: Dmitrii Golovanov <[email protected]>
sarathnandu
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
dnmokhov
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend the
Tachyon
example with additional command line optionn-of-iterations
to execute ray tracing (rendering) several times and collect its performance metrics to estimate relative error (for rendering duration at the moment).Extend the
Primes
example'sn-of-repeats
execution mode to calculate relative error for each of the parallel threadsexecution block (
n-of-threads
), so it is now possible to measure their performance reliability.Extend the
Sudoku
example with additional option to repeat solution several times and calculate relative error to estimate performance reliability.The relative error allows to take informed decision on how reliable and reproduceable these examples are as oneTBB benchmarks, or some additional stabilization is required to achieve some KPI (e.g. 5% max).
Resolves: #1656 (part of)
Type of change
Tests
Documentation
Breaks backward compatibility
Notify the following users
@anchita20
@mehulBhandari20
Other information
class measurements
introduced with #1446 is moved to its own header file to make its use easier deep in example applications without conflicts with other utility classes.Intel OSS Hackathon 2025