chore: address and remove TODOs

Author: rpechuk

packages/publish/README.md

@@ -1,4 +1,4 @@
-# mosaic-publish TODO: Adjust this doc 
+# mosaic-publish
 
 A CLI tool for compiling and optimizing specifications. The tool processes spec files, handles dataset optimizations, and provides a configurable way to manage different compile and optimization tasks.
 

packages/publish/src/MosaicPublisher.ts

@@ -267,6 +267,7 @@ export class MosaicPublisher {
    */
   private async exportDataFromDuckDB(tables: Record<string, Set<string>>) {
     const copy_queries: string[] = [];
+    let containsPreAggData = false;
     for (const node of Object.values(this.data!)) {
       if (!(node instanceof ParquetDataNode)) continue;
       const table = node.name;
@@ -290,12 +291,15 @@ export class MosaicPublisher {
           throw new Error(`Invalid optimization level: ${this.optimize}`);
       }
       copy_queries.push(query);
+
+      if (file.startsWith('.mosaic')) {
+        containsPreAggData = true;
+      }
     }
 
     if (copy_queries.length > 0) {
-      // TODO: Make the following conditionally on data needs
       fs.mkdirSync(path.join(this.outputPath, 'data'), { recursive: true });
-      fs.mkdirSync(path.join(this.outputPath, 'data/.mosaic'), { recursive: true });
+      if (containsPreAggData) fs.mkdirSync(path.join(this.outputPath, 'data/.mosaic'), { recursive: true });
 
       await this.ctx.coordinator.exec(copy_queries);
     }

packages/publish/src/util/renderHelpers.ts

@@ -2,15 +2,14 @@ import { MosaicClient } from "@uwdata/mosaic-core/src/MosaicClient.js";
 import { InstantiateContext } from "@uwdata/mosaic-spec";
 import { Canvas } from "skia-canvas";
 
-export function mockCanvas (window: any) {
+export function mockCanvas(window: any) {
     const og = window.document.createElement
     window.document.createElement = function (tagName: string) {
         if (tagName !== 'canvas') {
             return og.call(this, tagName)
         } else {
             const canvas = new Canvas();
             const el = og.call(this, tagName) as HTMLCanvasElement;
-            // TODO: this is a hack to get around the fact that the canvas is not a real canvas
             el.getContext = canvas.getContext.bind(canvas) as unknown as HTMLCanvasElement['getContext'];
             el.toDataURL = canvas.toDataURLSync.bind(canvas);
             const set = el.setAttribute;
@@ -27,6 +26,6 @@ export function mockCanvas (window: any) {
 }
 
 export function clientsReady(ctx: InstantiateContext) {
-  const clients = [...ctx.coordinator.clients] as MosaicClient[];
-  return Promise.allSettled(clients.map(c => c.pending));
+    const clients = [...ctx.coordinator.clients] as MosaicClient[];
+    return Promise.allSettled(clients.map(c => c.pending));
 }