Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to '*-DEM.tif' - do not assume out_dem_gsd #75

Closed
dshean opened this issue Feb 1, 2025 · 1 comment · Fixed by #77
Closed

Default to '*-DEM.tif' - do not assume out_dem_gsd #75

dshean opened this issue Feb 1, 2025 · 1 comment · Fixed by #77
Labels
bug Something isn't working

Comments

@dshean
Copy link
Member

dshean commented Feb 1, 2025

The default ASP output is outprefix-DEM.tif

Right now the asp_plot/stereo.py module assumes the DEM filename has format outprefix-DEM_{out_dem_gsd}m.tif or outprefix-{out_dem_gsd}m_DEM.tif

WARNING:asp_plot.utils:Could not find ('*-DEM_1m.tif', '*1m-DEM.tif') in WV02_20250131_103001010D1F0700_103001010DA86400/mgm_crop. Some plots may be missing.

Which results in a ValueError:

No DEM found in WV02_20250131_103001010D1F0700_103001010DA86400/mgm_crop with GSD 1 m. Please run stereo processing with the desired

This should not be the default. We should not assume they have an integer value and unit here.

A better option here might be to allow users to override the DEM filename.

@dshean dshean added the bug Something isn't working label Feb 1, 2025
@bpurinton bpurinton linked a pull request Feb 5, 2025 that will close this issue
@bpurinton
Copy link
Contributor

A better option here might be to allow users to override the DEM filename.

I like this as an option. It's implemented now on #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants