Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emitting default values support in JSON #84

Open
wish-master opened this issue Mar 25, 2020 · 2 comments
Open

Add emitting default values support in JSON #84

wish-master opened this issue Mar 25, 2020 · 2 comments

Comments

@wish-master
Copy link
Contributor

It will be great if I can paste some flag to generator which pass EmitDefaults value in default marshaler. This option is well discussed in that thread: grpc-ecosystem/grpc-gateway#233
I suppose to make it optional with false as default value not to change current behavior.
I'm talking about flag exactly, not to develop some custom httpruntime.Marshaler implementation and injection... If @utrack will be agree, I'll implement this feature.

@bullgare
Copy link
Contributor

I'd be interested in this feature as well.

@utrack
Copy link
Owner

utrack commented Apr 1, 2020

It's a great idea, I believe :) I'm all for it if you'll manage to override marshaler settings per-handler, without breaking global injection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants