Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JS to check user agent #54

Open
gpspake opened this issue Oct 12, 2015 · 2 comments
Open

Use JS to check user agent #54

gpspake opened this issue Oct 12, 2015 · 2 comments
Assignees
@gpspake

Comments

@gpspake
Copy link
Member

gpspake commented Oct 12, 2015

We're using PHP to check the user's browser and add an empty div beneath the off canvas buttons for Safari on iOS devices. As far as I can tell, this is the only place we're doing this and it's is something we should be able to do with javascript, possibly with which browser
@gpspake
Copy link
Member Author

gpspake commented Oct 12, 2015

I'm going to close #12 and include it with this issue "Site should check for Safari, specifically, not just iphone/ipad. Also, look in to whether it would be better to use js or continue to use php."

Right now, we're just checking for ios so the empty div is appearing on all browsers on iOS even though safari is the only one with the bottom menu causing problems.

@gpspake gpspake mentioned this issue Oct 12, 2015
Closed
@gpspake gpspake self-assigned this Oct 12, 2015
@gpspake
Copy link
Member Author

gpspake commented Oct 14, 2015

Actually, Todd and I discussed this yesterday and thought it would be better to use PHP. I'm good with that; which browser looks like it includes a server side script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gpspake gpspake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gpspake