Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS - In-page navigation: Update reference to data-header-selector #5836

Open
amyleadem opened this issue Mar 25, 2024 · 0 comments · May be fixed by #5856
Open

USWDS - In-page navigation: Update reference to data-header-selector #5836

amyleadem opened this issue Mar 25, 2024 · 0 comments · May be fixed by #5856
Assignees
@amyleadem
Labels
Package: In-page navigation Role: Dev Development/engineering skills needed
Milestone
uswds 3.8.1

Comments

@amyleadem
Copy link
Contributor

Summary

There is an outdated reference to data-header-selector in the in-page navigation JS. This should be updated to reference the data-heading-elements attribute instead.

Related issue

Related to uswds/uswds-site#2559
@amyleadem amyleadem self-assigned this Mar 25, 2024
@github-actions github-actions bot added the Status: Triage We're triaging this issue and grooming if necessary label Mar 25, 2024
@amyleadem amyleadem added Package: In-page navigation and removed Status: Triage We're triaging this issue and grooming if necessary labels Mar 25, 2024
@amyleadem amyleadem added this to the uswds 3.9.0 milestone Mar 25, 2024
@amyleadem amyleadem mentioned this issue Mar 25, 2024
Merged
@amyleadem amyleadem modified the milestones: uswds 3.9.0, uswds 3.8.1 Apr 9, 2024
@amyleadem amyleadem linked a pull request Apr 9, 2024 that will close this issue
Open
@amyleadem amyleadem added the Role: Dev Development/engineering skills needed label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amyleadem amyleadem

Labels
Package: In-page navigation Role: Dev Development/engineering skills needed
Projects
USWDS Core Project Data
Status: Fed Final Review
Milestone
uswds 3.8.1
Development

Successfully merging a pull request may close this issue.

USWDS - In-page navigation: Update reference to data-heading-elements sttribute uswds/uswds
1 participant
@amyleadem