Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move anything from notebooks/typology/* into notebooks/archive/typology/*? #215

Closed
jGaboardi opened this issue Dec 7, 2024 · 1 comment · Fixed by #216
Closed

move anything from notebooks/typology/* into notebooks/archive/typology/*? #215

jGaboardi opened this issue Dec 7, 2024 · 1 comment · Fixed by #216

Comments

@jGaboardi
Copy link
Collaborator

I want to finish up #177 (which will also close out #175) , in doing so completely removing all modules in the algorithms subpackage. As far as I can tell, the only stuff left using anything from algorithms/ are the notebooks in typology/.

  • I am curious if we want to migrate any of them into notebooks/archive/typology/*?
  • Since all that functionality is baked into neatnet do we even just want to plop them into a notebooks/archive/typology/* without any updates?

(Bullet 2 is by far the lighter lift)

cc @martinfleis @anastassiavybornova

@martinfleis
Copy link
Contributor

Those were exploratory so I'm fine with dumping them to archive. We could add a note that if someone really wants to rerun those, they can checkout older commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants