Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop extension of bananas #118

Closed
martinfleis opened this issue Jul 30, 2024 · 5 comments
Closed

Develop extension of bananas #118

martinfleis opened this issue Jul 30, 2024 · 5 comments
Assignees

Comments

@martinfleis
Copy link
Contributor

We're missing quite a bit of polygons along highways in our detection. I think that we should figure out some smart way of expanding it. We now do 1% over the threshold if they are adjacent but I think that we'll need to go deeper and allow extension with lower circular compactness to go beyond that 1%. Haven't looked into that yet but the most striking issues in the result are due to missing artifacts where I would expect them.

@martinfleis
Copy link
Contributor Author

For some reason, the way we do it now does not detect artifacts properly in Salt Lake City. Only 277 get detected, I sense some issue with peaks.

@anastassiavybornova
Copy link
Collaborator

  • try: focus on circular compactness - polygons that are very elongated
  • mostly salt lake city. more artifacts than urban blocks - does the number matter?

@anastassiavybornova
Copy link
Collaborator

@martinfleis the salt lake city one is solved by not using service roads, but i wonder whether we should keep this open to integrate the future final version of get_artifacts into FaceArtifacts, too?

@martinfleis
Copy link
Contributor Author

Let's keep this open for now.

@martinfleis
Copy link
Contributor Author

I think this is mostly solved now. The rest can be left to uscuni/neatnet#15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants