Skip to content

Commit bcb2774

Browse files
authored
reup cityseer method with new sequence + fresh FUA results (#213)
* add curated cityseer manual cleaning guide - v4.17.2 * rerun updated cityseer sequence * fresh cityseer result by FUA * pixi-kernel to pyproject.toml & pizi.lock * pixi.lock [2] * temp removal * correction in testing.yml * updated expected edge counts for cityseer method * removed wrong diff from conflict
1 parent 863301c commit bcb2774

File tree

13 files changed

+4963
-10357
lines changed

13 files changed

+4963
-10357
lines changed

.github/workflows/testing.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@
4545
run: 'pixi run -e tests python -c "import geopandas; geopandas.show_versions();"'
4646

4747
- name: run tests
48-
run:
49-
pixi run -e tests pytest -v -r a -n logical --color yes --cov code --cov-append --cov-report term-missing --cov-report xml .
48+
run: |
49+
pixi run -e tests pytest core -v -r a -n logical --color yes --cov core --cov-append --cov-report term-missing --cov-report xml .
5050
5151
- name: codecov
5252
uses: codecov/codecov-action@v4

core/tests/test_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def test_read_sample_data():
2727
xnd2_records = [43_233, 12_439, 16_302, 30_552, 16_554, 13_468, 29_314]
2828

2929
# results records
30-
cityseer_records = [40591, 10083, 14659, 28940, 14893, 12796, 26070]
30+
cityseer_records = [39_715, 9740, 14_130, 28_187, 14_325, 12_382, 25_666]
3131
man_records = [38_772, 8_640, 14_170, 29_252, 13_508, 11_032, 30_225]
3232
neatnet_records = [39_489, 8_229, 13_587, 29_028, 12_395, 11_059, 16_298]
3333
osmnx_records = [43_451, 15_770, 24_025, 37_954, 21_755, 17_704, 30_156]

data/1133/cityseer/1133.parquet

-11 KB
Binary file not shown.

data/1656/cityseer/1656.parquet

-13.2 KB
Binary file not shown.

data/4617/cityseer/4617.parquet

-4.48 KB
Binary file not shown.

data/4881/cityseer/4881.parquet

-7.73 KB
Binary file not shown.

data/809/cityseer/809.parquet

-9.35 KB
Binary file not shown.

data/869/cityseer/869.parquet

-9.63 KB
Binary file not shown.

data/8989/cityseer/8989.parquet

-14.7 KB
Binary file not shown.

notebooks/methods/cityseer.ipynb

Lines changed: 653 additions & 165 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)