From e300678efdb0564e39ca3865b8657a8d366d37d8 Mon Sep 17 00:00:00 2001
From: James Gaboardi <jgaboardi@gmail.com>
Date: Tue, 26 Nov 2024 11:13:59 -0500
Subject: [PATCH 1/2] update pre-commit

---
 .pre-commit-config.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 2daaa61..1d5a054 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -1,7 +1,7 @@
 files: "sgeop\/"
 repos:
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: "v0.6.9"
+    rev: "v0.8.0"
     hooks:
       - id: ruff
       - id: ruff-format

From ff6a21cf0a562948a53f659dd454db99d22a08da Mon Sep 17 00:00:00 2001
From: James Gaboardi <jgaboardi@gmail.com>
Date: Tue, 26 Nov 2024 11:14:58 -0500
Subject: [PATCH 2/2] doctring for simply.simplfy_loop()

---
 sgeop/simplify.py | 72 ++++++++++++++++++++++++++++++++++-------------
 1 file changed, 52 insertions(+), 20 deletions(-)

diff --git a/sgeop/simplify.py b/sgeop/simplify.py
index 3800721..e1cfee8 100644
--- a/sgeop/simplify.py
+++ b/sgeop/simplify.py
@@ -489,8 +489,15 @@ def simplify_network(
 ) -> gpd.GeoDataFrame:
     """Top-level workflow for simplifying networks. The input raw road network data is
     first preprocessed (topological corrections & node consolidation) before two
-    iterations of artifact detection and simplification. For further information on
-    face artifact detection and extraction see :cite:`fleischmann2023`.
+    iterations of artifact detection and simplification.
+
+    Each iteration of the simplification procedure which includes (1.) the removal
+    of false nodes; (2.) face artifact classification; and (3.) the line-based
+    simplification of face artifacts in the order of single artifacts, pairs of
+    artifacts, clusters of artifacts.
+
+    For further information on face artifact detection and extraction
+    see :cite:`fleischmann2023`.
 
     Parameters
     ----------
@@ -616,30 +623,55 @@ def simplify_network(
 
 
 def simplify_loop(
-    roads,
-    artifacts,
-    max_segment_length=1,
-    min_dangle_length=20,
-    clip_limit: int = 2,
-    simplification_factor=2,
-    consolidation_tolerance=10,
-    eps=1e-4,
-):
-    """
+    roads: gpd.GeoDataFrame,
+    artifacts: gpd.GeoDataFrame,
+    max_segment_length: float | int = 1,
+    min_dangle_length: float | int = 20,
+    clip_limit: float | int = 2,
+    simplification_factor: float | int = 2,
+    consolidation_tolerance: float | int = 10,
+    eps: float = 1e-4,
+) -> gpd.GeoDataFrame:
+    """Perform an iteration of the simplification procedure which includes:
+        1. Removal of false nodes
+        2. Artifact classification
+        3. Simplifying artifacts:
+            - Single artifacts
+            - Pairs of artifacts
+            - Clusters of artifacts
 
     Parameters
     ----------
-
-    clip_limit : int = 2
-        Following generation of the Voronoi linework in ``geometry.voronoi_skeleton()``,
-        we clip to fit inside the polygon. To ensure we get a space to make proper
-        topological connections from the linework to the actual points on the edge of
-        the polygon, we clip using a polygon with a negative buffer of ``clip_limit``
-        or the radius of maximum inscribed circle, whichever is smaller.
+    roads : geopandas.GeoDataFrame
+        Raw road network data.
+    artifacts : geopandas.GeoDataFrame
+        Face artifact polygons.
+    max_segment_length : float | int = 1
+        Additional vertices will be added so that all line segments
+        are no longer than this value. Must be greater than 0.
+        Used in multiple internal geometric operations.
+    min_dangle_length : float | int
+        The threshold for determining if linestrings are dangling slivers to be
+        removed or not.
+    clip_limit : float | int = 2
+        Following generation of the Voronoi linework, we clip to fit inside the
+        polygon. To ensure we get a space to make proper topological connections
+        from the linework to the actual points on the edge of the polygon, we clip
+        using a polygon with a negative buffer of ``clip_limit`` or the radius of
+        maximum inscribed circle, whichever is smaller.
+    simplification_factor : float | int = 2
+        The factor by which singles, pairs, and clusters are simplified. The
+        ``max_segment_length`` is multiplied by this factor to get the
+        simplification epsilon.
+    consolidation_tolerance : float | int = 10
+        Tolerance passed to node consolidation when generating Voronoi skeletons.
+    eps : float = 1e-4
+        Tolerance epsilon used in multiple internal geometric operations.
 
     Returns
     -------
-
+    geopandas.GeoDataFrame
+        The road network line data following 1 iteration of simplification.
     """
 
     # Remove edges fully within the artifact (dangles).