Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: simplfy._identify_non_planar() -- imperfect 3CC artifacts? #10

Open
jGaboardi opened this issue Jul 31, 2024 · 1 comment
Open

TODO: simplfy._identify_non_planar() -- imperfect 3CC artifacts? #10

jGaboardi opened this issue Jul 31, 2024 · 1 comment
Assignees
@martinfleis
Labels
algo/method

Comments

@jGaboardi
Copy link
Collaborator

jGaboardi commented Jul 31, 2024 •
edited
Loading

neatnet/neatnet/simplify.py

Lines 88 to 90 in dfb9290

# Note from within `simplify_singletons()`
# TODO: This is not perfect.
# TODO: Some 3CC artifacts were non-planar but not captured here.

xref uscuni/simplification#95
@jGaboardi jGaboardi transferred this issue from uscuni/simplification Oct 3, 2024
@jGaboardi

This comment was marked as outdated.

Sign in to view
@jGaboardi jGaboardi changed the title TODO: core.algorithms.simplfy.simplify_singletons() -- imperfect 3CC artifacts? TODO: simplfy.simplify_singletons()._identify_non_planar() -- imperfect 3CC artifacts? Dec 5, 2024
@jGaboardi jGaboardi changed the title TODO: simplfy.simplify_singletons()._identify_non_planar() -- imperfect 3CC artifacts? TODO: simplfy._identify_non_planar() -- imperfect 3CC artifacts? Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinfleis martinfleis

Labels
algo/method
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jGaboardi @martinfleis