-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path toward testing with a released version of hypercorn? #3334
Comments
Hey @musicinmybrain, thanks for this. And as a Fedora user, thanks for your packaging work! We switched to Hypercorn because it supports HTTP/2 (unlike Tornado), so switching back isn't an option. Sorry that this causes you more work. :( We definitely want to merge our changes upstream, but had little success so far. The urllib3-changes branch contains three important changes for us:
@pgjones What do you think about the above? How can we best help you add those features? We can direct some of our HTTP/2 funding to Hypercorn work on those three issues. |
Thank you for writing a full and clear explanation in one place! I have a working proof of concept for introducing |
My general issue is time, of which I have very little. PRs are welcome though. |
Context
Since 2.2.0, the
urllib3
test suite relies heavily onhypercorn
, but it’s a special patched hypercorn:urllib3/dev-requirements.txt
Lines 19 to 22 in c42b4ba
I followed the links, but what I can’t tell is, is this something expected to continue indefinitely? Or is there a reasonable path toward using a released version of Hypercorn in the future?
As a Fedora Linux packager, it’s straightforward for me to create a new
python-hypercorn
package in order to run urllib3’s tests during the RPM build, but it’s fairly impractical for me to use a special forked copy of Hypercorn that isn’t packaged.Alternatives
I can stop running the tests, which greatly increases the risk of undetected regressions.
I might be able to bundle a copy of the “special Hypercorn” to use for running the tests, but this is a very unusual approach that would be messy and tedious to maintain. I plan to experiment with this.
Duplicate
I don’t think this has been requested before.
Contribution
I would be willing to submit PR’s to this project or to Hypercorn, although I don’t have a deep understanding of either project’s internals and I am not likely to study them enough to reach that point.
The text was updated successfully, but these errors were encountered: