Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gimme 1.6.0 #113296

Closed
wants to merge 2 commits into from
Closed

gimme 1.6.0 #113296

wants to merge 2 commits into from

Conversation

meatballhat
Copy link

@meatballhat meatballhat commented Oct 17, 2022

Created with brew bump-formula-pr.

Given new home and new release.

I realize there are security and/or political implications here given I'm requesting the formula point at a different source. You should be able to see in the history at travis-ci/gimme that I have been a core contributor since the beginning when the repository was at meatballhat/gimme. I'm happy to answer any questions around why I'm taking over maintenance again (see relevant issue).

Closes urfave/gimme#5

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Oct 17, 2022
@SMillerDev
Copy link
Member

Is there any reference upstream announcing that you are the new maintainer?

@carlocab carlocab added maintainer feedback Additional maintainers' opinions may be needed automerge-skip `brew pr-automerge` will skip this pull request labels Oct 17, 2022
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me; thanks for the update!

@iMichka
Copy link
Member

iMichka commented Oct 19, 2022

Given there was no answer on travis-ci/gimme#206 but it has only been 9 days, I would like to wait a little bit (let's say max 30 days).

It's a weird situation, and the explanation is really clear. If we get no answer, I'm fine with going ahead with the fork.

@meatballhat
Copy link
Author

Is there any reference upstream announcing that you are the new maintainer?

It's a bit weird, because I personally have been the maintainer for most of the project history, but I got laid off from Travis CI in 2019 after an acquisition. I'd like to get maintenance flowing again, and my attempts to work with current Travis CI maintainers haven't gone anywhere 😐 But, to @iMichka's point, I'm happy to wait a bit longer 😁

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Oct 23, 2022
@carlocab carlocab added in progress Stale bot should stay away and removed stale No recent activity labels Oct 23, 2022
@MikeMcQuaid
Copy link
Member

@meatballhat I sympathise with your position, that sounds rough ❤️. I feel like we need to hold off a migration until the "official" upstream approves it somewhere/somehow, just to avoid setting a precedent with this in future. Hopefully you understand we need to be overly cautious on this sort of thing 🙇🏻

@meatballhat
Copy link
Author

@MikeMcQuaid Absolutely, I understand! Thank you ❤️

@iMichka
Copy link
Member

iMichka commented Dec 11, 2022

I've asked upstream one more time for a clarification: travis-ci/gimme#206 (comment)

@p-linnane
Copy link
Member

Upstream is still silent on this. I think it is time for us to make a decision one way or another. How do we want to handle it?

@MikeMcQuaid
Copy link
Member

@p-linnane If upstream is silent: we need to create a new formula with a new name and can consider deprecating this one.

@p-linnane
Copy link
Member

@MikeMcQuaid Last commits were this past June, and v1.5.5 was cut then. Maybe we should wait a few more months on deprecation.

@meatballhat If you'd still like to add your fork, please open a PR for it with a new name.

@p-linnane p-linnane closed this Jan 17, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` in progress Stale bot should stay away maintainer feedback Additional maintainers' opinions may be needed outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Homebrew source
7 participants