New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove go generate
from v2 build process
#1801
Comments
abitrolly
added
kind/bug
describes or fixes a bug
area/v2
relates to / is being considered for v2
status/triage
maintainers still need to look into this
labels
Jul 23, 2023
@abitrolly Do you really want to optimize this since we are moving forward with v3 ? Does the analysis apply to v3 ? |
@dearchap yes. That will make |
v3 doesn't seem the be affected. |
bartekpacia
changed the title
De-generate v2 build process
Remove May 2, 2024
go generate
from v2 build process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
My urfave/cli version is
v2
Checklist
Dependency Management
Describe the bug
The generation step when calling
make
from https://cli.urfave.org/CONTRIBUTING/#development-workflow takes way too much detours.Observed behavior
Expected behavior
At least this.
Additional context
go generate
except callingmake
fromurfave-cli-genflags
go generate
is not called duringgo build
process, so there is no implicit automation hereDid I miss anything?
Want to fix this yourself?
Yup. If there is no some hidden magic behind.
The text was updated successfully, but these errors were encountered: