boot: replay in subprocess #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemfb
requested changes
May 24, 2024
matthew-levan
commented
May 26, 2024
pkova
added a commit
that referenced
this pull request
May 29, 2024
Adds `--lmdb-map-size` to specify LMDB's initial memory mapping size, intended for use by users who need a size smaller than our default of 500G. Note: `case 12` to avoid collision with the other arg added in #654.
pkova
approved these changes
Jun 24, 2024
pkova
added a commit
that referenced
this pull request
Jun 28, 2024
This PR fixes an issue introduced in #654, whereby docked binaries could not replay.
joemfb
added a commit
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
--serf-binoption for specifying a serf executableu3_Host.wrk_cto--serf-bin's value if specified, self otherwise_cw_playthat exits if it readsEOFfromSTDIN(thereby ensuring the child process for replaying events exits whenever the parent is killed)These changes allow Ares (or any other runtime) to implement its own
playsubcommand and have Vere use it for the boot process's replay functionality.Tests:
linux-x86_64subcommand, replay via boot, killing king via INT, KILL, TERMmacos-aarch64subcommand, replay via boot, killing king via INT, KILL, TERM