Skip to content

Commit 2d4f76c

Browse files
authored
Version 4.3.4 (#125)
* Remove the default value for store param * Fix rubocop issues * Update changelog
1 parent d3c96ed commit 2d4f76c

File tree

8 files changed

+19
-13
lines changed

8 files changed

+19
-13
lines changed

.rubocop.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ AllCops:
22
NewCops: enable
33
TargetRubyVersion: 2.7
44

5-
Metrics/LineLength:
5+
Layout/LineLength:
66
Max: 120
77

8-
IneffectiveAccessModifier:
8+
Lint/IneffectiveAccessModifier:
99
Enabled: false
1010

1111
Style/HashTransformKeys:

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# Changelog
22

3+
## 4.3.4 — 2023-05-16
4+
5+
### Changed
6+
7+
* Use `auto` as the default value for the `store` param.
8+
9+
310
## 4.3.3 — 2023-04-14
411

512
### Changed

Gemfile

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,12 @@
22

33
source 'https://rubygems.org'
44

5+
gem 'byebug', '~> 11.1'
6+
gem 'rake', '~> 13.0'
7+
gem 'rspec', '~> 3.0'
8+
gem 'rubocop', '~> 1.48'
9+
gem 'vcr', '~> 6.1'
10+
gem 'webmock', '~> 3.18'
11+
512
# Specify your gem's dependencies in uploadcare-ruby.gemspec
613
gemspec

lib/uploadcare/client/multipart_upload_client.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ def upload(object, options = {}, &block)
2525

2626
# Asks Uploadcare server to create a number of storage bin for uploads
2727
def upload_start(object, options = {})
28-
options.merge!(store: options[:store] || false)
2928
body = HTTP::FormData::Multipart.new(
3029
Param::Upload::UploadParamsGenerator.call(options).merge(form_data_for(object))
3130
)

lib/uploadcare/entity/conversion/base_converter.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ class << self
1010
# Converts files
1111
#
1212
# @param doc_params [Array] of hashes with params or [Hash]
13-
# @option options [Boolean] :store (false) whether to store file on servers.
13+
# @option options [Boolean] :store whether to store file on servers.
1414
def convert(params, options = {})
1515
files_params = params.is_a?(Hash) ? [params] : params
1616
conversion_client.new.convert_many(files_params, options)

lib/uploadcare/entity/uploader.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class Uploader < Entity
1515
#
1616
# @param object [Array], [String] or [File]
1717
# @param [Hash] options options for upload
18-
# @option options [Boolean] :store (false) whether to store file on servers.
18+
# @option options [Boolean] :store whether to store file on servers.
1919
def self.upload(object, options = {})
2020
if big_file?(object)
2121
multipart_upload(object, options)

lib/uploadcare/ruby/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# frozen_string_literal: true
22

33
module Uploadcare
4-
VERSION = '4.3.3'
4+
VERSION = '4.3.4'
55
end

uploadcare-ruby.gemspec

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,4 @@ Gem::Specification.new do |spec|
4747
spec.add_dependency 'parallel', '~> 1.22'
4848
spec.add_dependency 'retries', '~> 0.0'
4949
spec.add_dependency 'uploadcare-api_struct', '>= 1.1', '< 2'
50-
51-
spec.add_development_dependency 'byebug', '~> 11.1'
52-
spec.add_development_dependency 'rake', '~> 13.0'
53-
spec.add_development_dependency 'rspec', '~> 3.0'
54-
spec.add_development_dependency 'rubocop', '~> 1.48'
55-
spec.add_development_dependency 'vcr', '~> 6.1'
56-
spec.add_development_dependency 'webmock', '~> 3.18'
5750
end

0 commit comments

Comments
 (0)