New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming of PhysicalSystem Class #31

Open

atra94 opened this issue May 11, 2020 · 1 comment

Labels

Collaborator

atra94 commented May 11, 2020

In my opinion, the name PhysicalSystem could be improved for more clarity on its purpose.

The PhysicalSystem is the part to combine all models of the subsystems (Motors, Loads, Converters etc.) into one and to execute the simulation.

Therefore I would suggest to name it "SystemModel" or "CompoundSystem".

I would also appreachiate more and better suggestions. 😃

atra94 added the enhancement label

Collaborator

wallscheid commented Jun 19, 2020

Good initiative, but requirse bird's eye view on the entire could package. Renaming on global basis in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment