Skip to content

Rename ACME certificate verification response proto field from Token to Authorization #3890

@coderabbitai

Description

@coderabbitai

Problem

In the ACME certificate verification response proto, we currently have a field named Token that actually contains the ACME key authorization value, not the raw token. This creates semantic confusion.

Current Implementation

In go/apps/ctrl/services/acme/certificate_verification.go:

res.Msg.Token = challenge.Authorization

The field name Token is misleading because we're actually returning the ACME key authorization.

Proposed Solution

Rename the proto field from Token to Authorization to accurately reflect its contents.

Changes needed:

  1. Update the proto definition to rename the field
  2. Update the Go code to use the new field name
  3. Update any callers/tests that reference this field

Context

ACME Specification Context

According to the ACME HTTP-01 challenge specification, the server should serve the key authorization (which is token + "." + account_key_thumbprint), not just the raw token.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions