Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support webpack 5 #73

Open
otakustay opened this issue Oct 17, 2020 · 11 comments
Open

Support webpack 5 #73

otakustay opened this issue Oct 17, 2020 · 11 comments

Comments

@otakustay
Copy link

What problem does this feature solve?

I used webpackbar with webpack 5 for a while and found no compatibility issue, since npm 7 requires peer dependencies to match strictly, it is better to publish a new version upgrading peerDependencies to enable webpack 5

This feature request is available on Nuxt community (#c47)
@pi0
Copy link
Member

pi0 commented Oct 19, 2020

Hi! Thanks for notice about NPM. Same here we are also using it for nuxt3 with wp5 without any special issues.

@nicholas-ochoa
Copy link

I'm having issues installing it (when no package-lock.json is present from npm 6.x):

$ npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: @company/[email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/webpack
npm ERR!   dev webpack@"^5.1.3" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer webpack@"^3.0.0 || ^4.0.0" from [email protected]
npm ERR! node_modules/webpackbar
npm ERR!   dev webpackbar@"^4.0.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/username/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/username/.npm/_logs/2020-10-19T20_22_41_253Z-debug.log

npm install --legacy-peer-deps works for now, but this package will definitely need to be updated

@Tom910
Copy link

Tom910 commented Oct 23, 2020

I founded 1 problem with webpack 5 is broken feature profile. But main feature work fine

@pi0
Copy link
Member

pi0 commented Nov 2, 2020

Hi. Webpack5 support is almost finished (6ba2f82) releasing soon && sorry for delay

@ckken
Copy link

ckken commented Nov 21, 2020

Hi. Webpack5 support is almost finished (6ba2f82) releasing soon && sorry for delay

thanks

@ckken
Copy link

ckken commented Jan 9, 2021

mark

@thasmo
Copy link

thasmo commented Feb 5, 2021

Happens now in webpack 5 projects on npm install with npm@7:

npm ERR! Could not resolve dependency:
npm ERR! peer webpack@"^3.0.0 || ^4.0.0" from [email protected]
npm ERR! node_modules/webpackbar
npm ERR!   webpackbar@"^4.0.0" from the root project

@alexander-akait
Copy link

alexander-akait commented Apr 2, 2021

Maybe we don't need this plugin and move bar style to webpack core? Should be easy. Will be great to get feedback and improve built-in output and nobody need this plugin anymore, less deps and no problems with update

/cc @pi0

@pi0
Copy link
Member

pi0 commented Apr 2, 2021

Webpack5 ready plugin is already available as [email protected] (pre-release tag) :) I will run some final tests and mark at latest.

Maybe we don't need this plugin and move bar style to webpack core? Should be easy. Will be great to get feedback and improve built-in output and nobody need this plugin anymore, less deps and no problems with update

It would be a really nice idea if we can port this functionality directly into the webpack core. The most tricky part is multi-line output control. I guess we need to first extract bar functionality and then we can propose it :)

@alexander-akait
Copy link

It would be a really nice idea if we can port this functionality directly into the webpack core. The most tricky part is multi-line output control. I guess we need to first extract bar functionality and then we can propose it :)

Yep, feel free to feedback, I will help ⭐

@thasmo
Copy link

thasmo commented Oct 13, 2021

@pi0 Has there been any progress on webpack 5 compatibility since ... then? 😅 Would love to use webpackbar with webpack 5. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants