Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withQuery do not encode ';' #240

Open
zhangsn opened this issue May 11, 2024 · 0 comments
Open

withQuery do not encode ';' #240

zhangsn opened this issue May 11, 2024 · 0 comments

Comments

@zhangsn
Copy link

zhangsn commented May 11, 2024

Environment

Not related

Reproduction

var ufo = require("ufo")
console.log(ufo.withQuery("/foo?page=a", { token: "sec;ret" }));
//should output /foo?page=a&secret=sec%3Bret

Describe the bug

ufo use encodeURI not encodeURIComponent to encode query value,therefore ';' is not encoded

see:

return encodeURI("" + text).replace(ENC_PIPE_RE, "|");

Is there any special reason to use encodeURI?

Additional context

No response

Logs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant