Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route matcher is always strict about trailing slashes #87

Closed
pi0 opened this issue Mar 8, 2024 · 1 comment · Fixed by #91
Closed

Route matcher is always strict about trailing slashes #87

pi0 opened this issue Mar 8, 2024 · 1 comment · Fixed by #91
Labels
bug Something isn't working

Comments

@pi0
Copy link
Member

pi0 commented Mar 8, 2024

Context: unjs/nitro#2146

Reproduction: https://stackblitz.com/edit/stackblitz-starters-ijst6y

Router created by createRadixRouter is non strict about trailing slashes by default.

While route matcher created by toRouteMatcher is strict about trailing slashes.

(Note: this is a bug but also fix could potentially be breaking behavior change)

@lwpinion
Copy link

lwpinion commented Mar 8, 2024

@pi0, does this bug directly relate to the fact that my routes with trailing slashes do not work? Or is this more about making sure radix is consistent about how it handles trailing slashes?

@pi0 pi0 closed this as completed in #91 Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants